Skip to content

Update compat to CxxWrap 0.16 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Update compat to CxxWrap 0.16 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
261c16f
Update compat to CxxWrap 0.16
odow Oct 26, 2024
0c8c142
Bump LTS
blegat Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['1.6', '1'] # Test against LTS
version: ['1.10', '1'] # Test against LTS
Copy link

@schillic schillic Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new SDPA version does not work on v1.6 but v1.6 is still marked as compatible in Project.toml. So now the new SDPA version installs in v1.6 and breaks.
(UndefVarError: get_libsdpawrap_path not defined)

Copy link
Member

@blegat blegat Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I bumped it but I went to fast, let's update it on the registry

Copy link
Member

@blegat blegat Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by JuliaRegistries/General#119139

os: [ubuntu-latest, macOS-latest, windows-latest]
arch: [x64]
# TODO(odow): Fix this
Expand Down
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
SDPA_jll = "7fc90fd6-dbef-5a6a-93f8-169f2a2e705b"

[compat]
CxxWrap = "0.14"
CxxWrap = "0.16"
LinearAlgebra = "<0.0.1, 1.6"
MathOptInterface = "1"
SDPA_jll = "=700.300.1701"
SDPA_jll = "=700.300.1800"
SparseArrays = "<0.0.1, 1.6"
Test = "<0.0.1, 1.6"
julia = "1.6"
Expand Down
Loading