Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect feature sub-selection #804

Closed
jumpinjackie opened this issue Jan 29, 2019 · 7 comments · Fixed by #929

Comments

@jumpinjackie
Copy link
Owner

commented Jan 29, 2019

I have received reports that the feature sub-selection may be highlighting the wrong feature. That is: The attributes of the current feature does not reflect what was sub-selected.

@jumpinjackie jumpinjackie added the bug label Jan 29, 2019
@jumpinjackie jumpinjackie added this to the 0.12 milestone Jan 29, 2019
@jumpinjackie jumpinjackie self-assigned this Jan 29, 2019
@RenoSun

This comment has been minimized.

Copy link

commented May 2, 2019

Yes, I have the same issue as well! :)

@jumpinjackie

This comment has been minimized.

Copy link
Owner Author

commented May 3, 2019

Are your selection problems coming from Oracle layers by any chance?

@RenoSun

This comment has been minimized.

Copy link

commented May 3, 2019

The layers coming from SQL Server 2016, and I built the Configuration Document to link to each table.

@jumpinjackie

This comment has been minimized.

Copy link
Owner Author

commented May 29, 2019

@RenoSun Could I trouble you with a minimal SQL Server db extract + MapGuide package that demonstrates the problem? You can just provide tables with only the id/geometry columns and only a subset of the rows.

@RenoSun

This comment has been minimized.

Copy link

commented May 30, 2019

Hi @jumpinjackie,

I really hope this will help you to figure what's wrong. I tried to export only the data with ID and GEOM, but it seems not creating the same issue. So I decided to give you the data more than two columns including values with html (hyperlink). I found the highlight error doesn't occur occasionally when you select small amount of features on the map, but definitely found the wrong highlighting when selecting more than 10 features on the map. We're still using AIMS 2017, and I don't know if that may cause any issues with the mapguide-react-layout,
TestParcel.zip

Please see the following GIF:
ezgif com-optimize

@jumpinjackie

This comment has been minimized.

Copy link
Owner Author

commented Jul 30, 2019

@RenoSun I was finally able to take a look at your dataset and was able to reproduce the inconsistent sub-selection. This was the offending selection inferred from your provided gif (I'm posting this for future reference for myself).

2019-07-31 01_16_34-TestParcel - Brave

I have a worrying suspicion that this sub-selection feature was built on a fatally-flawed assumption that the <SelectFeatures> content would be rendered out in the same order as the selection keys under <FeatureSet>. Further debugging will prove if this is the case.

jumpinjackie added a commit that referenced this issue Aug 5, 2019
…RES v4.0.0 introduced with MapGuide RFC 176. It is this version of the operation that allows us to properly implement feature sub-selection. As a result, we no longer support feature sub-selection for versions older than 4.0 as we cannot rely on array index lookup to locate the correct selection key.
@jumpinjackie

This comment has been minimized.

Copy link
Owner Author

commented Aug 5, 2019

Ok, here's the deal.

I have a fix, but this requires a new version of QUERYMAPFEATURES to support this (which I've put together in this RFC: https://trac.osgeo.org/mapguide/wiki/MapGuideRfc176).

Because the fix requires a new API, it means I have to remove support for this feature on versions older than MGOS 4.0 as I cannot rely on array index lookup to correctly find the corresponding feature selection key (which is how feature sub-selection is currently implemented).

The fix is parked on a feature branch pending approval/adoption of the above RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.