Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Potentially incorrect feature sub-selection #804
I really hope this will help you to figure what's wrong. I tried to export only the data with ID and GEOM, but it seems not creating the same issue. So I decided to give you the data more than two columns including values with html (hyperlink). I found the highlight error doesn't occur occasionally when you select small amount of features on the map, but definitely found the wrong highlighting when selecting more than 10 features on the map. We're still using AIMS 2017, and I don't know if that may cause any issues with the mapguide-react-layout,
@RenoSun I was finally able to take a look at your dataset and was able to reproduce the inconsistent sub-selection. This was the offending selection inferred from your provided gif (I'm posting this for future reference for myself).
I have a worrying suspicion that this sub-selection feature was built on a fatally-flawed assumption that the
…RES v4.0.0 introduced with MapGuide RFC 176. It is this version of the operation that allows us to properly implement feature sub-selection. As a result, we no longer support feature sub-selection for versions older than 4.0 as we cannot rely on array index lookup to locate the correct selection key.
Ok, here's the deal.
I have a fix, but this requires a new version of
Because the fix requires a new API, it means I have to remove support for this feature on versions older than MGOS 4.0 as I cannot rely on array index lookup to correctly find the corresponding feature selection key (which is how feature sub-selection is currently implemented).
The fix is parked on a feature branch pending approval/adoption of the above RFC.