New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymaps not bound to data-grammar and conflict with other plugins #28

Open
billglover opened this Issue Apr 28, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@billglover

billglover commented Apr 28, 2016

It would be good to limit the scope of the keymap to the graphviz data-grammar to prevent (or at least reduce) the possibility of a clash with other plugins.

There is currently a conflict when using the atom-tasks plugin. That plugin limits the scope of the Ctrl-D keymap to the todo data-grammar as below.

# For more detailed documentation see
# https://atom.io/docs/latest/advanced/keymaps
'.platform-darwin atom-workspace atom-text-editor:not(.mini)[data-grammar~="todo"]':
  'ctrl-d': 'tasks:complete'

In the graphviz-preview plugin there is no such limitation meaning the keymap is global.

# For more detailed documentation see
# https://atom.io/docs/latest/advanced/keymaps
'atom-workspace':
  'ctrl-d': 'graphviz-preview:toggle'

I would like to propose limiting the scope to the graphviz data-grammar. It may be possible to combine this enhancement with a fix for Issue #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment