Floating Windows Support From Neovim #664

Piping · 2018-07-01T05:10:35Z

Neovim patch from @bfredl has a working version of floating windows implementation now.

Is it possible to add a split direction like float and then open fzf inside floating windows.

The text was updated successfully, but these errors were encountered:

junegunn · 2018-07-03T06:29:45Z

You can pass an arbitrary command as window option.

function! Foo()
  tabnew
  " or whatever
endfunction

call fzf#run({'window': 'call Foo()'})

See https://github.com/junegunn/fzf/blob/master/README-VIM.md#fzfrun for details.

Piping · 2018-07-03T06:40:11Z

@junegunn Thanks a bunch

Piping · 2018-07-03T06:58:05Z

function! Foo()
     if exists('*nvim_open_float_win')
         let b = nvim_create_buf(v:false)
         call nvim_buf_set_option(b, "buftype", "nofile")
         call nvim_buf_set_lines(b,0,-1,v:true,["test"])
         let opts = {'x':100, 'y':5, 'anchor': 'NE'}
         let w =  nvim_open_float_win(b,v:false,60,20,opts)
         hi Floating guibg=#000000
         call setwinvar(w, '&winhl', 'Normal:Floating')
         call setwinvar(w, '&number', 0)
     endif
 endfunction
 call fzf#run({'window': 'call Foo()'})

I tried the following script, but fzf windows is not opened inside the floating windows, any idea?

How does fzf window option locate the window?

junegunn · 2018-07-03T09:17:34Z

It opens in the "current" window where your cursor is positioned.

bfredl · 2018-07-03T10:14:38Z

@Piping change v:false to v:true in the open float call.

Piping · 2018-07-04T06:05:14Z

@bfredl Thanks!

This is what I got!

@junegunn
Awesome.

Although if I adjust the gui terminal size, the nvim crashed.

nvim: ../src/nvim/ui_compositor.c:226: compose_line: Assertion `until <= default_grid.Columns' failed.

@bfredl

kassio · 2019-03-25T16:09:40Z

I got a nice result with the following:

let g:fzf_layout = { 'window': 'call FloatingFZF()' }
function! FloatingFZF()
  let buf = nvim_create_buf(v:false, v:true)
  call setbufvar(buf, '&signcolumn', 'no')

  let winheight = winheight(0)
  let winwidth = winwidth(0)

  let width = float2nr(winwidth-(winwidth*2/10))

  let opts = {
        \ 'relative': 'editor',
        \ 'row': &lines - 3,
        \ 'col': float2nr((winwidth-width)/2),
        \ 'width': width,
        \ 'height': &lines - 3
        \ }

  call nvim_open_win(buf, v:true, opts)
endfunction

I was trying to achieve a different visual with the "input" in the top and the list of files in a top-down layout, but with the current fzf customization tools I didn't find a way to do it.

kassio · 2019-03-25T18:33:07Z

little change to keep the floating window centralized horizontally, regardless of any vertical splits.

function! FloatingFZF()
  let buf = nvim_create_buf(v:false, v:true)
  call setbufvar(buf, '&signcolumn', 'no')

  let width = float2nr(&columns - (&columns * 2 / 10))
  let height = &lines - 3
  let y = &lines - 3
  let x = float2nr((&columns - width) / 2)

  let opts = {
        \ 'relative': 'editor',
        \ 'row': y,
        \ 'col': x,
        \ 'width': width,
        \ 'height': height
        \ }

  call nvim_open_win(buf, v:true, opts)
endfunction

junegunn · 2019-03-26T01:02:59Z

a different visual with the "input" in the top and the list of files in a top-down layout

See Layout section in the man page.

kassio · 2019-03-26T01:27:20Z

Thanks @junegunn, I got the visual that I wanted:

let $FZF_DEFAULT_OPTS='--layout=reverse'
let g:fzf_layout = { 'window': 'call FloatingFZF()' }

function! FloatingFZF()
  let buf = nvim_create_buf(v:false, v:true)
  call setbufvar(buf, '&signcolumn', 'no')

  let height = &lines - 3
  let width = float2nr(&columns - (&columns * 2 / 10))
  let col = float2nr((&columns - width) / 2)

  let opts = {
        \ 'relative': 'editor',
        \ 'row': 1,
        \ 'col': col,
        \ 'width': width,
        \ 'height': height
        \ }

  call nvim_open_win(buf, v:true, opts)
endfunction

glepnir · 2019-03-27T08:19:34Z

@kassio hi i use this function， how to hide line number in float window？setlocal nonumber ? where it should be write

sassanh · 2019-03-27T09:39:52Z

change

call nvim_open_win(buf, v:true, opts)

to

let win = nvim_open_win(buf, v:true, opts)
call setwinvar(win, '&number', 0)

glepnir · 2019-03-27T09:44:17Z

@sassanh nothing change.

sassanh · 2019-03-27T09:52:02Z

It's working for me:

    let win = nvim_open_win(l:buf, v:true, l:opts)
    call timer_start(0, {-> execute(':call setwinvar(' . l:win . ', "&number", 1)')})

And this (not changing anything in the function):

autocmd! FileType fzf
autocmd  FileType fzf setlocal nonumber

kassio · 2019-03-27T10:25:18Z

You can use:

  au FileType fzf set nonu nornu

Just saw that @sassanh already mention that, sorry for the noise.

glepnir · 2019-03-27T10:28:55Z

@kassio @sassanh add this call setwinvar(win, '&relativenumber', 0),works well,by the way how to change fzf backgournd highlight.

sassanh · 2019-03-27T10:32:47Z

Put this at the end of your init.vim (or just after color scheme is set in your init.vim)

highlight NormalFloat cterm=NONE ctermfg=14 ctermbg=0 gui=NONE guifg=#93a1a1 guibg=#002931

junegunn/fzf.vim#664

Based on junegunn/fzf.vim#664 (comment)

AhmedAbdulrahman · 2019-10-13T05:16:35Z

Hi @kassio Thanks for the cool tips, do you know how can I get ride of that annoying Flashing background color when I open fzf ?

dagadbm · 2019-12-04T12:30:55Z

" floating fzf
if has('nvim')
  let $FZF_DEFAULT_OPTS .= ' --layout=reverse'

  function! FloatingFZF()
    let buf = nvim_create_buf(v:false, v:true)

   " here be dragoons
    let height = &lines
    let width = float2nr(&columns - (&columns * 2 / 10))
    let col = float2nr((&columns - width) / 2)
    let col_offset = &columns / 10
    let opts = {
          \ 'relative': 'editor',
          \ 'row': 1,
          \ 'col': col + col_offset,
          \ 'width': width * 2 / 1,
          \ 'height': height / 2
          \ }

    let win = nvim_open_win(buf, v:true, opts)
    call setwinvar(win, '&winhl', 'NormalFloat:TabLine')

  " this is to remove all line numbers and so on from the window
    setlocal
          \ buftype=nofile
          \ nobuflisted
          \ bufhidden=hide
          \ nonumber
          \ norelativenumber
          \ signcolumn=no
  endfunction

  let g:fzf_layout = { 'window': 'call FloatingFZF()' }
endif

this is a mix from junegunn dotfiles, comment from this thread and space-vim config
although i have no idea what this does exactly but it seems to work.

if you guys have better alternatives do share here !

Karmenzind · 2019-12-10T06:02:21Z

call setwinvar(win, '&winhl', 'NormalFloat:TabLine') will be better @dagadbm

kassio · 2019-12-10T14:48:36Z

@AhmedAbdulrahman is that still happening? For me, it's not happening. 🤷‍♂

dagadbm · 2019-12-10T16:09:32Z

call setwinvar(win, '&winhl', 'NormalFloat:TabLine') will be better @dagadbm

changed it!

why is it better?

alfunx · 2019-12-10T21:30:08Z

You usually don't need the setlocal stuff anymore if you set the minimal stile in opts, e.g.:

" floating fzf
if has('nvim')
  let $FZF_DEFAULT_OPTS .= ' --layout=reverse'

  function! FloatingFZF()
    let height = &lines
    let width = float2nr(&columns - (&columns * 2 / 10))
    let col = float2nr((&columns - width) / 2)
    let col_offset = &columns / 10
    let opts = {
          \ 'relative': 'editor',
          \ 'row': 1,
          \ 'col': col + col_offset,
          \ 'width': width * 2 / 1,
          \ 'height': height / 2,
          \ 'style': 'minimal'
          \ }
    let buf = nvim_create_buf(v:false, v:true)
    let win = nvim_open_win(buf, v:true, opts)
    call setwinvar(win, '&winhl', 'NormalFloat:TabLine')
  endfunction

  let g:fzf_layout = { 'window': 'call FloatingFZF()' }
endif

nstetter · 2019-12-17T10:12:37Z

How would I change the background color for the FloatWindow in @alfunx example?

marcov · 2019-12-17T12:28:07Z

How would I change the background color for the FloatWindow in @alfunx example?

@nstetter use highlight TabLine ctermbg=<code>

alfunx · 2019-12-17T23:19:41Z

@nstetter If you want to change the color for all floating windows and just use that color, set the NormalFloat group and remove the following line:

call setwinvar(win, '&winhl', 'NormalFloat:TabLine')

If you want to use a different colors for that specific floating window (while leaving the other ones as they are now), exchange Tabline with some other highlighting group, e.g.:

call setwinvar(win, '&winhl', 'NormalFloat:Error')

You can also define a highlighting group yourself and then use that, e.g.

highlight SpecificFloat ctermbg=... ctermfg=...

nstetter · 2019-12-18T10:50:54Z

Thanks for the explanation.
I found it more applicable to change the background color using the minimal style option and the FZF_DEFAULT_OPTS variable.

One thing I am still having issues with is the layout option. I set --layout=reverse
But it does not get respected, as can be seen in the screenshot:

My whole config is:

    " Using floating windows of Neovim to start fzf
    if has('nvim-0.4.0')
      let $FZF_DEFAULT_OPTS .= '--color=bg:#20242C --border --layout=reverse'
      function! FloatingFZF()
	let width = float2nr(&columns * 0.9)
	let height = float2nr(&lines * 0.6)
	let opts = { 'relative': 'editor',
		   \ 'row': (&lines - height) / 2,
		   \ 'col': (&columns - width) / 2,
		   \ 'width': width,
		   \ 'height': height,
		   \ 'style': 'minimal'
		   \}

	let win = nvim_open_win(nvim_create_buf(v:false, v:true), v:true, opts)
	call setwinvar(win, '&winhighlight', 'NormalFloat:TabLine')
      endfunction

      let g:fzf_layout = { 'window': 'call FloatingFZF()' }
    endif

When echoing $FZF_DEFAULT_OPTS inside vim I get:

--multi
--color=dark
--color=fg:-1,bg:-1,hl:#c678dd,fg+:#ffffff,bg+:#4b5263,hl+:#d858fe
--color=info:#98c379,prompt:#61afef,pointer:#be5046,marker:#e5c07b,spinner:#61afef,header:#61afef
--color=bg:#20242C --border --layout=reverse

Any idea why the reverse layout does not work like that?

junegunn · 2019-12-18T11:14:54Z

@nstetter 👉 #916

yutkat · 2020-02-20T17:24:11Z

https://github.com/yuki-ycino/fzf-preview.vim

Piping closed this as completed Jul 3, 2018

Piping reopened this Jul 3, 2018

Piping closed this as completed Jul 3, 2018

Piping reopened this Jul 3, 2018

Piping closed this as completed Jul 4, 2018

Piping reopened this Jul 4, 2018

Piping mentioned this issue Jul 4, 2018

[RFC] Floating windows in TUI and Remote UI neovim/neovim#6619

Merged

junegunn closed this as completed Mar 26, 2019

tfmoraes mentioned this issue Mar 26, 2019

Support neovim float window #786

Closed

6 tasks

sassanh mentioned this issue Apr 8, 2019

Floating window in neovim dense-analysis/ale#2424

Closed

MaryHal added a commit to MaryHal/nvim_config that referenced this issue May 26, 2019

Added floating fzf snippet

d355d1c

junegunn/fzf.vim#664

junegunn mentioned this issue Jun 8, 2019

Floating Windows Support VIM Popup #821

Closed

9 tasks

elentok added a commit to elentok/dotfiles that referenced this issue Jul 6, 2019

feat(nvim): use floating window for fzf

cfa13c4

Based on junegunn/fzf.vim#664 (comment)

This was referenced Jul 7, 2019

floating window lotabout/skim.vim#4

Closed

Pass window command to fzf#run alok/notational-fzf-vim#45

Merged

resolritter mentioned this issue Sep 15, 2019

Code for creating full-width floating window no longer works neovim/neovim#11012

Closed

mcchrish mentioned this issue Sep 17, 2019

Support vim popup mcchrish/nnn.vim#46

Closed

Floating Windows Support From Neovim #664

Floating Windows Support From Neovim #664

Piping commented Jul 1, 2018

junegunn commented Jul 3, 2018

Piping commented Jul 3, 2018

Piping commented Jul 3, 2018 •

edited

junegunn commented Jul 3, 2018

bfredl commented Jul 3, 2018

Piping commented Jul 4, 2018 •

edited

kassio commented Mar 25, 2019

kassio commented Mar 25, 2019

junegunn commented Mar 26, 2019

kassio commented Mar 26, 2019

glepnir commented Mar 27, 2019

sassanh commented Mar 27, 2019 •

edited

glepnir commented Mar 27, 2019

sassanh commented Mar 27, 2019 •

edited

kassio commented Mar 27, 2019 •

edited

glepnir commented Mar 27, 2019 •

edited

sassanh commented Mar 27, 2019 •

edited

AhmedAbdulrahman commented Oct 13, 2019

dagadbm commented Dec 4, 2019 •

edited

Karmenzind commented Dec 10, 2019

kassio commented Dec 10, 2019

dagadbm commented Dec 10, 2019

alfunx commented Dec 10, 2019 •

edited

nstetter commented Dec 17, 2019

marcov commented Dec 17, 2019

alfunx commented Dec 17, 2019

nstetter commented Dec 18, 2019

junegunn commented Dec 18, 2019

yutkat commented Feb 20, 2020

Floating Windows Support From Neovim #664

Floating Windows Support From Neovim #664

Comments

Piping commented Jul 1, 2018

junegunn commented Jul 3, 2018

Piping commented Jul 3, 2018

Piping commented Jul 3, 2018 • edited

junegunn commented Jul 3, 2018

bfredl commented Jul 3, 2018

Piping commented Jul 4, 2018 • edited

kassio commented Mar 25, 2019

kassio commented Mar 25, 2019

junegunn commented Mar 26, 2019

kassio commented Mar 26, 2019

glepnir commented Mar 27, 2019

sassanh commented Mar 27, 2019 • edited

glepnir commented Mar 27, 2019

sassanh commented Mar 27, 2019 • edited

kassio commented Mar 27, 2019 • edited

glepnir commented Mar 27, 2019 • edited

sassanh commented Mar 27, 2019 • edited

AhmedAbdulrahman commented Oct 13, 2019

dagadbm commented Dec 4, 2019 • edited

Karmenzind commented Dec 10, 2019

kassio commented Dec 10, 2019

dagadbm commented Dec 10, 2019

alfunx commented Dec 10, 2019 • edited

nstetter commented Dec 17, 2019

marcov commented Dec 17, 2019

alfunx commented Dec 17, 2019

nstetter commented Dec 18, 2019

junegunn commented Dec 18, 2019

yutkat commented Feb 20, 2020

Piping commented Jul 3, 2018 •

edited

Piping commented Jul 4, 2018 •

edited

sassanh commented Mar 27, 2019 •

edited

sassanh commented Mar 27, 2019 •

edited

kassio commented Mar 27, 2019 •

edited

glepnir commented Mar 27, 2019 •

edited

sassanh commented Mar 27, 2019 •

edited

dagadbm commented Dec 4, 2019 •

edited

alfunx commented Dec 10, 2019 •

edited