Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bash-completion] Fix endless loop when completion.bash sourced twice #2250

Merged
merged 1 commit into from Nov 14, 2020

Conversation

liskin
Copy link
Contributor

@liskin liskin commented Nov 13, 2020

I forgot to add the "not _fzf" check into __fzf_orig_completion, so
invoking it twice would rewrite the _fzf_orig_completion_xxx variables
and then cause an endless loop when completion is requested.

Fixes: #2246
Reported-by: @wingpin6

I forgot to add the "not _fzf" check into __fzf_orig_completion, so
invoking it twice would rewrite the _fzf_orig_completion_xxx variables
and then cause an endless loop when completion is requested.

Fixes: ef2c29d ("[bash-completion] Optimize __fzf_orig_completion_filter")
liskin added a commit to liskin/dotfiles that referenced this pull request Nov 13, 2020
@junegunn junegunn merged commit 7bd99a2 into junegunn:master Nov 14, 2020
1 check passed
@junegunn
Copy link
Owner

Thanks for the quick fix!

@liskin liskin deleted the bash-completion branch November 14, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants