New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support to embedded fonts as byte array #79

Merged
merged 2 commits into from Jul 30, 2016

Conversation

Projects
None yet
2 participants
@prsolucoes
Contributor

prsolucoes commented Jul 28, 2016

I have added support to embedded fonts (from []byte). With this you can use "https://github.com/jteeuwen/go-bindata" to create the files from fonts.

I already it with success in my project:
https://github.com/prsolucoes/godiffexporter/blob/master/main.go

Advantages:

  • Everything already is on memory
  • The binary can be distributed without font files

Check my Makefile to see an example of how to generate the file with embedded fonts:
https://github.com/prsolucoes/godiffexporter/blob/master/Makefile

Thanks.

@jung-kurt

This comment has been minimized.

Show comment
Hide comment
@jung-kurt

jung-kurt Jul 28, 2016

Owner

Thanks, @prsolucoes, for a useful contribution. I'll merge it in when I think of the best way to demonstrate it for end-users. Probably this will be in the form of a test with sufficient documentation to show how a Go resource file is created.

Nice work!

Owner

jung-kurt commented Jul 28, 2016

Thanks, @prsolucoes, for a useful contribution. I'll merge it in when I think of the best way to demonstrate it for end-users. Probably this will be in the form of a test with sufficient documentation to show how a Go resource file is created.

Nice work!

@prsolucoes

This comment has been minimized.

Show comment
Hide comment
@prsolucoes

prsolucoes Jul 29, 2016

Contributor

Hi,

So i made the tests now to you merge it.

Thanks.

Contributor

prsolucoes commented Jul 29, 2016

Hi,

So i made the tests now to you merge it.

Thanks.

@jung-kurt jung-kurt merged commit b432677 into jung-kurt:master Jul 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jung-kurt

This comment has been minimized.

Show comment
Hide comment
@jung-kurt

jung-kurt Jul 30, 2016

Owner

Thanks @prsolucoes

I isolated the rather large binary files to help with editing the test source file. Also, I used the calligra font to avoid copyright issues.

Owner

jung-kurt commented Jul 30, 2016

Thanks @prsolucoes

I isolated the rather large binary files to help with editing the test source file. Also, I used the calligra font to avoid copyright issues.

@jung-kurt

This comment has been minimized.

Show comment
Hide comment
@jung-kurt

jung-kurt Jul 30, 2016

Owner

@prsolucoes If you would like to be acknowledged in the README, what name should I use?

Owner

jung-kurt commented Jul 30, 2016

@prsolucoes If you would like to be acknowledged in the README, what name should I use?

@prsolucoes

This comment has been minimized.

Show comment
Hide comment
@prsolucoes

prsolucoes Jul 30, 2016

Contributor

Hi,

Thanks. You can use my name "Paulo Coutinho" or my business name "PRSoluções" if you want.

Contributor

prsolucoes commented Jul 30, 2016

Hi,

Thanks. You can use my name "Paulo Coutinho" or my business name "PRSoluções" if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment