Skip to content
This repository has been archived by the owner. It is now read-only.

adding support to embedded fonts as byte array #79

Merged
merged 2 commits into from Jul 30, 2016

Conversation

@prsolucoes
Copy link
Contributor

prsolucoes commented Jul 28, 2016

I have added support to embedded fonts (from []byte). With this you can use "https://github.com/jteeuwen/go-bindata" to create the files from fonts.

I already it with success in my project:
https://github.com/prsolucoes/godiffexporter/blob/master/main.go

Advantages:

  • Everything already is on memory
  • The binary can be distributed without font files

Check my Makefile to see an example of how to generate the file with embedded fonts:
https://github.com/prsolucoes/godiffexporter/blob/master/Makefile

Thanks.

@jung-kurt
Copy link
Owner

jung-kurt commented Jul 28, 2016

Thanks, @prsolucoes, for a useful contribution. I'll merge it in when I think of the best way to demonstrate it for end-users. Probably this will be in the form of a test with sufficient documentation to show how a Go resource file is created.

Nice work!

@prsolucoes
Copy link
Contributor Author

prsolucoes commented Jul 29, 2016

Hi,

So i made the tests now to you merge it.

Thanks.

@jung-kurt jung-kurt merged commit b432677 into jung-kurt:master Jul 30, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jung-kurt
Copy link
Owner

jung-kurt commented Jul 30, 2016

Thanks @prsolucoes

I isolated the rather large binary files to help with editing the test source file. Also, I used the calligra font to avoid copyright issues.

@jung-kurt
Copy link
Owner

jung-kurt commented Jul 30, 2016

@prsolucoes If you would like to be acknowledged in the README, what name should I use?

@prsolucoes
Copy link
Contributor Author

prsolucoes commented Jul 30, 2016

Hi,

Thanks. You can use my name "Paulo Coutinho" or my business name "PRSoluções" if you want.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.