New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong showing of colors, which shouldn't be there. #11

Closed
Chris2011 opened this Issue Aug 1, 2017 · 11 comments

Comments

Projects
None yet
2 participants
@Chris2011

Chris2011 commented Aug 1, 2017

After I update to the newest version of your plugin, I got false positives for colors:

should-not-be-there

and

should-not-be-there-too

so as you can see, the text contains white and green so it will show that, which is false. The second example is a scss variable, where another color is inside, which is linked to this ticket: #7

Regards

Chris

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Aug 1, 2017

Owner

I know that things. So, I added the option for named colors. (It is disabled by default.) Probably, it can be improved a bit for specific languages. If you can get unexpected results at the moment, just uncheck the option.

Thanks for your understanding.

Owner

junichi11 commented Aug 1, 2017

I know that things. So, I added the option for named colors. (It is disabled by default.) Probably, it can be improved a bit for specific languages. If you can get unexpected results at the moment, just uncheck the option.

Thanks for your understanding.

@Chris2011

This comment has been minimized.

Show comment
Hide comment
@Chris2011

Chris2011 Aug 2, 2017

Maybe you can check whether it is a selector or a key or a value with regex. In HTML there happens to. There should be visible inside style="color: red". So I think with a regex it will work.

Chris2011 commented Aug 2, 2017

Maybe you can check whether it is a selector or a key or a value with regex. In HTML there happens to. There should be visible inside style="color: red". So I think with a regex it will work.

@Chris2011

This comment has been minimized.

Show comment
Hide comment
@Chris2011

Chris2011 Aug 2, 2017

<a href="" id="jsCopyBtn" class="link">{{ 'smth.shared.copy' | translate }}</a>

You only check for strings/words in each line right? It will show red because of shaRED.

Chris2011 commented Aug 2, 2017

<a href="" id="jsCopyBtn" class="link">{{ 'smth.shared.copy' | translate }}</a>

You only check for strings/words in each line right? It will show red because of shaRED.

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Aug 2, 2017

Owner

I already wrote: "Probably, it can be improved a bit for specific languages."

Owner

junichi11 commented Aug 2, 2017

I already wrote: "Probably, it can be improved a bit for specific languages."

@Chris2011

This comment has been minimized.

Show comment
Hide comment
@Chris2011

Chris2011 Aug 2, 2017

Why for specific languages? It only needs to be the value, that has to be a color name, no selector, no other string, no property. Only the value. And if there is a variable like $bla-green, than it is a variable and shouldn't be used.

Chris2011 commented Aug 2, 2017

Why for specific languages? It only needs to be the value, that has to be a color name, no selector, no other string, no property. Only the value. And if there is a variable like $bla-green, than it is a variable and shouldn't be used.

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Aug 2, 2017

Owner

Why cannot you wait at all?

Owner

junichi11 commented Aug 2, 2017

Why cannot you wait at all?

@Chris2011

This comment has been minimized.

Show comment
Hide comment
@Chris2011

Chris2011 Aug 2, 2017

Your initial answer, doesn't mean that you are working on it. Please be more specific at the next time. You only wrote: If you have side effects, just uncheck it. It doesn't mean, that you are working on it.

Chris2011 commented Aug 2, 2017

Your initial answer, doesn't mean that you are working on it. Please be more specific at the next time. You only wrote: If you have side effects, just uncheck it. It doesn't mean, that you are working on it.

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Aug 2, 2017

Owner

I wrote "at the moment". I'm not going to work on it soon. So I didn't write details. Anyway, you should wait a bit.

Owner

junichi11 commented Aug 2, 2017

I wrote "at the moment". I'm not going to work on it soon. So I didn't write details. Anyway, you should wait a bit.

@junichi11 junichi11 self-assigned this Aug 8, 2017

@junichi11 junichi11 added the defect label Aug 8, 2017

@junichi11 junichi11 added this to the 0.6.1 milestone Aug 8, 2017

junichi11 added a commit that referenced this issue Aug 8, 2017

Fix a named color problem #11
Check prefix and suffix of named colors
@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Aug 8, 2017

Owner

I've improved it a bit. Please try to test it (0.6.0.1-dev):
https://github.com/junichi11/netbeans-color-codes-preview/releases/tag/v0.6.0

Owner

junichi11 commented Aug 8, 2017

I've improved it a bit. Please try to test it (0.6.0.1-dev):
https://github.com/junichi11/netbeans-color-codes-preview/releases/tag/v0.6.0

@Chris2011

This comment has been minimized.

Show comment
Hide comment
@Chris2011

Chris2011 Aug 9, 2017

Looks ok for me. Thx for the work :)

Chris2011 commented Aug 9, 2017

Looks ok for me. Thx for the work :)

@Chris2011 Chris2011 closed this Aug 9, 2017

@junichi11

This comment has been minimized.

Show comment
Hide comment
@junichi11

junichi11 Aug 9, 2017

Owner

No problem :) Thanks for your verification.

Owner

junichi11 commented Aug 9, 2017

No problem :) Thanks for your verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment