Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated checkstyle setDir with new one #250

Merged
merged 1 commit into from May 2, 2020

Conversation

Bukama
Copy link
Member

@Bukama Bukama commented May 1, 2020

Fixes the checkstyle deprecation warnings, which is one of two warnings causing #246

The CheckstyleExtension.setConfigDir() method has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the CheckstyleExtension.getConfigDirectory().set() method instead. See https://docs.gradle.org/6.3/dsl/org.
gradle.api.plugins.quality.CheckstyleExtension.html#org.gradle.api.plugins.quality.CheckstyleExtension:configDir for more details.
        at Build_gradle$5.execute(build.gradle.kts:77)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@Bukama Bukama requested a review from aepfli May 1, 2020 13:36
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nipafx nipafx merged commit f95ede9 into junit-pioneer:master May 2, 2020
@Bukama Bukama deleted the bishue246/deprecatedgradle branch May 2, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants