Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spotless configuration for Groovy #484

Merged
merged 1 commit into from May 13, 2021
Merged

Remove Spotless configuration for Groovy #484

merged 1 commit into from May 13, 2021

Conversation

beatngu13
Copy link
Member

No separate issue for this one … 🙃

Proposed commit message:

Remove Spotless configuration for Groovy (#484)

Since 2649599 converted the build scripts to Kotlin DSL, Groovy is
no longer used and the corresponding Spotless configuration can
be removed.

PR: #484

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Since 2649599 converted build scripts to Kotlin DSL, Groovy is no
longer used and the corresponding Spotless configuration can be
removed.
@beatngu13 beatngu13 requested a review from aepfli May 12, 2021 22:48
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Copy link
Member

@Michael1993 Michael1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michael1993 Michael1993 merged commit 9e2c282 into junit-pioneer:main May 13, 2021
@beatngu13 beatngu13 deleted the rm-spotless-groovy-config branch May 13, 2021 21:59
@beatngu13 beatngu13 mentioned this pull request Jun 24, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants