Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GitHub Actions setup-java v3 #702

merged 1 commit into from Jan 3, 2023


Copy link

@sullis sullis commented Dec 26, 2022

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The contains information about the new extension


  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)


  • A prepared commit message exists
  • The list of contributions inside mentions the new contribution (real name optional)

@sullis sullis changed the title setup-java v3 ci: GitHub Actions setup-java v3 Dec 26, 2022
Copy link

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the fact that we don't have an underlying issue for that (short: In this case I personally don't need one) I accept the PR :)

I leave the final merge to the other maintainers.

@beatngu13 beatngu13 added the full-build Triggers full build suite on PR label Jan 3, 2023
Copy link

@sullis thank you for the update! 🙏 Will merge as soon as the full build passed.

@beatngu13 beatngu13 merged commit 4e3c7ed into junit-pioneer:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
full-build Triggers full build suite on PR
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants