Support timeouts for extensions

[dartyuhov]

Hi, I tried to set up timeouts for extension methods (BeforeAllCallback or AfterEachCallback) by using the @Timeout annotation with it, but it didn't work.

Also I've tried to set global timeouts such us junit.jupiter.execution.timeout.aftereach.method.default, and this also hasn't worked.

It would be great to see this feature in JUnit 5 next releases.

[marcphilipp]

@dartyuhov Can you use Assertions.assertTimeoutPreemptively(Duration, ThrowingSupplier<T>) in your extension instead?

[dartyuhov]

@marcphilipp thank you for quick reply!
Yes, as temporal solution I decided to use 'assertTimeoutPreemptively' method. But it still seems strange for me that extensions don't obey to whole project timeout rules. From my point of view extensions methods are same part of test lifecycle as common @beforeeach or @afterall(and so on) methods. Please correct me if I'm thinking wrong.

[marcphilipp]

You're not wrong. We initially decided against supporting @Timeout on extensions since we weren't sure how useful that will be. So you'd want to add @Timeout to your method definitions in your Extension implementation, right?

[dartyuhov]

yes, it would be useful from my point of view

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

[stale]

This issue has been automatically closed due to inactivity. If you have a good use case for this feature, please feel free to reopen the issue.

[SgtSilvio]

randomly stumbled upon this. While one can workaround with assertTimeoutPreemptively, it would be great if extensions follow the same timeout principles of being able to configure global default timeouts and overwriting them on specific methods if necessary.
Currently it is not possible to avoid stuck CI builds entirely by defining global timeout properties and all extensions need to carefully implement timeouts themselves (which is desired, but global timeouts for safety would be great).