-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Support void and Void class lookups in ReflectionUtils
#4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please add an "integration test" demonstrating the scenario from #4048 is now supported? |
"void" and "Void" class lookups in ReflectionUtils
This is now implicitly tested by |
marcphilipp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add an "integration test" demonstrating the scenario from #4048 is now supported?
This is now implicitly tested by
DefaultArgumentConverterTests.convertsStringToClass(). Should the newly introducedDefaultArgumentConverterTests.IntegrationTestsstill be retained?
Thanks! No, I don't think we need DefaultArgumentConverterTests.IntegrationTests.
Please add an entry to the 5.12.0-M1 release notes.
Removed.
As I'm not a native speaker feel free to change the text in the release notes. |
Signed-off-by: Björn Michael <b.michael@gmx.de>
Signed-off-by: Björn Michael <b.michael@gmx.de>
Signed-off-by: Björn Michael <b.michael@gmx.de>
"void" and "Void" class lookups in ReflectionUtilsvoid and Void class lookups in ReflectionUtils
|
Thanks, @bjmi! 👍 |
Fix #4048.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations