Skip to content

Conversation

@bjmi
Copy link
Contributor

@bjmi bjmi commented Oct 6, 2024

Fix #4048.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp
Copy link
Member

Could you please add an "integration test" demonstrating the scenario from #4048 is now supported?

sbrannen

This comment was marked as outdated.

@sbrannen sbrannen changed the title Support "void" in ReflectionUtils Support "void" and "Void" class lookups in ReflectionUtils Oct 6, 2024
@bjmi
Copy link
Contributor Author

bjmi commented Oct 6, 2024

Could you please add an "integration test" demonstrating the scenario from #4048 is now supported?

This is now implicitly tested by DefaultArgumentConverterTests.convertsStringToClass().
Should the newly introduced DefaultArgumentConverterTests.IntegrationTests still be retained?

Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an "integration test" demonstrating the scenario from #4048 is now supported?

This is now implicitly tested by DefaultArgumentConverterTests.convertsStringToClass(). Should the newly introduced DefaultArgumentConverterTests.IntegrationTests still be retained?

Thanks! No, I don't think we need DefaultArgumentConverterTests.IntegrationTests.

Please add an entry to the 5.12.0-M1 release notes.

@bjmi
Copy link
Contributor Author

bjmi commented Oct 7, 2024

Thanks! No, I don't think we need DefaultArgumentConverterTests.IntegrationTests.

Removed.

Please add an entry to the 5.12.0-M1 release notes.

As I'm not a native speaker feel free to change the text in the release notes.

bjmi added 3 commits October 7, 2024 17:59
Signed-off-by: Björn Michael <b.michael@gmx.de>
Signed-off-by: Björn Michael <b.michael@gmx.de>
Signed-off-by: Björn Michael <b.michael@gmx.de>
@marcphilipp marcphilipp requested a review from sbrannen October 8, 2024 08:23
@marcphilipp marcphilipp dismissed sbrannen’s stale review October 8, 2024 08:40

Feedback has been addressed

@marcphilipp marcphilipp changed the title Support "void" and "Void" class lookups in ReflectionUtils Support void and Void class lookups in ReflectionUtils Oct 8, 2024
@marcphilipp marcphilipp merged commit 0f27653 into junit-team:main Oct 8, 2024
@marcphilipp
Copy link
Member

Thanks, @bjmi! 👍

@bjmi bjmi deleted the void-support branch October 10, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support void class lookups in ReflectionUtils

3 participants