New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Eclipse compiler warnings #1042
Conversation
This fixes all compiler warnings in Eclipse. |
@@ -73,6 +73,7 @@ | |||
* @see TestResult | |||
* @see TestSuite | |||
*/ | |||
@SuppressWarnings("deprecation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually prefer that we suppress warnings at the narrowest place possible. There's a lot of code in this class, and I'd like to see if we introduce new references to deprecated code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I totally agree with you. In this case, however, adding @SuppressWarnings
on the class level is the only way to get rid of all deprecation warnings in TestClass
because its superclass Assert
is deprecated on the class-level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have just deprecated the methods in Assert
instead of the whole class, but I think that ship has sailed :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, okay by you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is fine
@kcooney I've added another commit to that fixes the serialization warning by adding a |
LGTM |
Good enough to merge it? |
Sorry, LGTM = "looks good to me" => "feel free to submit" :-) I was going to let you merge this because I wasn't sure if you wanted to have multiple commits or squash it (either is fine) |
You cannot pass `null` as a class literal: @ValidateWith(null) results in a compiler error.
FilterNotCreatedException does not add any fields to Exception.
08e6b86
to
23684f6
Compare
Fix Eclipse compiler warnings
I've split the various fixes into separate commits to illustrate why/how I fixed certain warnings.