Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @Rule for methods works only for TestRule but not for MethodRule #589

Closed
krystiannowak opened this issue Jan 3, 2013 · 7 comments · Fixed by #1015
Closed

Support @Rule for methods works only for TestRule but not for MethodRule #589

krystiannowak opened this issue Jan 3, 2013 · 7 comments · Fixed by #1015
Labels
needs more info up-for-grabs

Comments

@krystiannowak
Copy link

The support introduced in #83 seems to work now (in JUnit 4.11) only for org.junit.rules.TestRule implementations, but it misses org.junit.rules.MethodRule (un-deprecated again) when looking for methods annotated by @rule
@krystiannowak krystiannowak mentioned this issue Jan 3, 2013
Closed
@marcphilipp
Copy link
Member

@matthewfarwell Do you have time to take a look?

@dsaff
Copy link
Member

dsaff commented Jan 3, 2013

Ah, good point.

@matthewfarwell
Copy link
Contributor

Yes, I'll have a look when I have a minute or two...

@d0nutptr
Copy link

I'm thinking about contributing to this project. Mind if I take a swing at this?

@marcphilipp
Copy link
Member

Sure, go ahead. You would first have to verify this issue is (still) present.

@npathai
Copy link
Contributor

npathai commented Nov 1, 2014

@marcphilipp I have verified with latest build that the problem persists. BlockRunner does not call the MethodRules that are returned by annotated methods. I am on it. Pull request on the way.

@npathai
Copy link
Contributor

npathai commented Nov 1, 2014

Have resolved the issue and created pull request #1015

@npathai npathai mentioned this issue Nov 1, 2014
Merged
npathai added a commit to npathai/junit that referenced this issue Nov 1, 2014
@npathai
Incorporated the suggested changes related to Issue junit-team#589 by @…
1564255 
…kcooney
@npathai npathai mentioned this issue Nov 1, 2014
Closed
npathai added a commit to npathai/junit that referenced this issue Nov 2, 2014
@npathai
Issue junit-team#589 Made minor javadoc changes to tests
bb36d49
@npathai npathai mentioned this issue Nov 5, 2014
Merged
kcooney added a commit that referenced this issue Nov 5, 2014
@kcooney
Merge pull request #1015 from NarendraPathai/Issue589
8d057b4 
Resolved #589 where the method rules returned my methods were not e...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs more info up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolved #589 where the method rules returned my methods were not e... npathai/junit
6 participants
@dsaff @matthewfarwell @marcphilipp @krystiannowak @npathai @d0nutptr