Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1192: NotSerializableException with AssumptionViolatedException #1654

Merged

Conversation

@sirchia
Copy link
Contributor

@sirchia sirchia commented Feb 21, 2020

Fix for issue #1192: NotSerializableException with AssumptionViolatedException

This PR resolves issues where AssumptionViolatedExceptions can't be serialized due to a non-serializable Matcher and/or value object.
I've added tests to make sure serialization is compatible with previous versions and most of the 'magic' should be documented properly.

Cheers!
Riccardo Sirchia

…n writeObject serialization of AssumptionViolatedException
@sirchia sirchia requested a review from stefanbirkner Feb 21, 2020
@marcphilipp marcphilipp changed the base branch from master to main Jun 21, 2020
kcooney
kcooney approved these changes Jan 3, 2021
@marcphilipp marcphilipp added this to the 4.13.2 milestone Jan 4, 2021
@marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jan 4, 2021

@kcooney @stefanbirkner I added this to the 4.13.2 milestone. Any objections?

kcooney and others added 2 commits Jan 10, 2021
Give assertion methods shorter names.

Co-authored-by: Stefan Birkner <github@stefan-birkner.de>
Fix compile errors caused by previous commit.
@kcooney kcooney merged commit f8ee412 into junit-team:main Jan 11, 2021
5 checks passed
Copy link

@jc7020 jc7020 left a comment

src/test/resources/org/junit/assumptionViolatedExceptionWithoutValueAndMatcherCanBeReserialized_v4_13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants