Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated since jdk9 replacing constructor instance of Double and Float #1660

Merged
merged 2 commits into from Aug 2, 2020

Conversation

@RahulNagekar
Copy link
Contributor

@RahulNagekar RahulNagekar commented Apr 18, 2020

No description provided.

sync to latest
@marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Apr 19, 2020

Can't we simply rely on autoboxing?

@RahulNagekar RahulNagekar force-pushed the RahulNagekar:DeprecatedSinceJDK9 branch from caaab0f to 31e461e Apr 19, 2020
@RahulNagekar
Copy link
Contributor Author

@RahulNagekar RahulNagekar commented Apr 19, 2020

Can't we simply rely on autoboxing?

Right, good point.

@kcooney
Copy link
Member

@kcooney kcooney commented Apr 19, 2020

@marcphilipp @RahulNagekar I personally prefer not using autoboxing here. Having an explicit conversion here makes it clear to future readers that a conversion is happening.

@stefanbirkner
Copy link
Contributor

@stefanbirkner stefanbirkner commented Apr 23, 2020

I'm also in favour for Double.valueOf so that the code is the same like in JUnit 4's Assert.

@RahulNagekar
Copy link
Contributor Author

@RahulNagekar RahulNagekar commented Apr 23, 2020

I currently not sure if autoboxing would be more beneficial or valueOf (performance-wise).
As valueOf is used at many places in this file, I say keep it the same to preserve consistency in code.
:-)

Replacing Deprecated datatype constructors
@RahulNagekar RahulNagekar force-pushed the RahulNagekar:DeprecatedSinceJDK9 branch from f640dce to 4859dcb Apr 23, 2020
@stefanbirkner stefanbirkner added this to the 4.13.1 milestone Apr 25, 2020
@marcphilipp marcphilipp changed the base branch from master to main Jun 21, 2020
@kcooney
kcooney approved these changes Aug 2, 2020
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants