Make FrameworkField ctor public. Fixes #1668 #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcooney
changed the title
kcooney
requested changes
Jul 18, 2020
| @@ -9,7 +9,7 @@ private Version() { | |||
| } | |||
|
|
|||
| public static String id() { | |||
| return "4.13-SNAPSHOT"; | |||
| return "4.14-SNAPSHOT"; | |||
There was a problem hiding this comment.
Do you mind moving this change it's own commit (before the other changes)?
pholser
force-pushed
the
issues/1668/make-framework-field-ctor-public
branch
from
ff9ca34
to
c1203e0
Compare
Prior to this change, custom runners could make `FrameworkMethod` instances, but not `FrameworkField` instances. This small change allows for both now, because `FrameworkField`'s constructor has been promoted to `public` from package-private.
pholser
force-pushed
the
issues/1668/make-framework-field-ctor-public
branch
from
47f868e
to
5be301c
Compare
|
Whoops. Done. Thanks again! |
kcooney
approved these changes
Jul 26, 2020
This was referenced Oct 12, 2020
This was referenced Mar 15, 2021
chore(deps-dev): bump junit from 4.13 to 4.13.1 in /secretmanager
castuloramirez/java-docs-samples#7
Open
Closed
Closed
This was referenced May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Prior to this change, custom runners could make FrameworkMethod
instances, but not FrameworkField instances. This small change
allows for both now, because FrameworkFields constructor has been
promoted to public from package-private.