Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FrameworkField ctor public. Fixes #1668 #1669

Merged

Conversation

@pholser
Copy link
Contributor

@pholser pholser commented Jul 15, 2020

Prior to this change, custom runners could make FrameworkMethod
instances, but not FrameworkField instances. This small change
allows for both now, because FrameworkFields constructor has been
promoted to public from package-private.

@kcooney kcooney changed the title For #1668, make FrameworkField ctor public Make FrameworkField ctor public. Fixes #1668 Jul 18, 2020
@@ -9,7 +9,7 @@ private Version() {
}

public static String id() {
return "4.13-SNAPSHOT";
return "4.14-SNAPSHOT";

This comment has been minimized.

@kcooney

kcooney Jul 18, 2020
Member

Do you mind moving this change it's own commit (before the other changes)?

This comment has been minimized.

@pholser

pholser Jul 20, 2020
Author Contributor

Sure thing! Done.

@pholser pholser force-pushed the pholser:issues/1668/make-framework-field-ctor-public branch from ff9ca34 to c1203e0 Jul 20, 2020
Paul Holser
Prior to this change, custom runners could make `FrameworkMethod`
instances, but not `FrameworkField` instances. This small change
allows for both now, because `FrameworkField`'s constructor has been
promoted to `public` from package-private.
@pholser pholser force-pushed the pholser:issues/1668/make-framework-field-ctor-public branch from 47f868e to 5be301c Jul 22, 2020
@pholser
Copy link
Contributor Author

@pholser pholser commented Jul 22, 2020

Whoops. Done. Thanks again!

@kcooney kcooney merged commit 714019f into junit-team:main Aug 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marcphilipp marcphilipp added this to the 4.13.1 milestone Oct 11, 2020
@marcphilipp marcphilipp linked an issue that may be closed by this pull request Oct 11, 2020
@marcphilipp marcphilipp removed this from the 4.13.1 milestone Oct 11, 2020
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants