Make FrameworkField ctor public. Fixes #1668 #1669
Merged
Conversation
kcooney
changed the title
| @@ -9,7 +9,7 @@ private Version() { | |||
| } | |||
|
|
|||
| public static String id() { | |||
| return "4.13-SNAPSHOT"; | |||
| return "4.14-SNAPSHOT"; | |||
kcooney
Jul 18, 2020
Member
Do you mind moving this change it's own commit (before the other changes)?
Do you mind moving this change it's own commit (before the other changes)?
pholser
Jul 20, 2020
Author
Contributor
Sure thing! Done.
Sure thing! Done.
pholser
force-pushed the
pholser:issues/1668/make-framework-field-ctor-public
branch
from
ff9ca34
to
c1203e0
Prior to this change, custom runners could make `FrameworkMethod` instances, but not `FrameworkField` instances. This small change allows for both now, because `FrameworkField`'s constructor has been promoted to `public` from package-private.
pholser
force-pushed the
pholser:issues/1668/make-framework-field-ctor-public
branch
from
47f868e
to
5be301c
|
Whoops. Done. Thanks again! |
This was referenced Oct 12, 2020
This was referenced Mar 15, 2021
Open
chore(deps-dev): bump junit from 4.13 to 4.13.1 in /secretmanager
castuloramirez/java-docs-samples#7
Open
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Prior to this change, custom runners could make FrameworkMethod
instances, but not FrameworkField instances. This small change
allows for both now, because FrameworkFields constructor has been
promoted to public from package-private.