Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly wrap float parameter for consistency #1671

Merged
merged 1 commit into from Sep 6, 2020

Conversation

@T45K
Copy link
Contributor

@T45K T45K commented Aug 4, 2020

In #1141, while this param named actual was unwrapped, other params are still wrapped in Double or Float#valueOf.
I consider that its wrapping is necessary for consistency.

@kcooney
kcooney approved these changes Sep 5, 2020
@marcphilipp marcphilipp changed the title Boxing param of float type Explicitly wrap float parameter for consistency Sep 6, 2020
@marcphilipp marcphilipp merged commit b6cfd1e into junit-team:main Sep 6, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Sep 6, 2020

Thanks, @T45K! 👍

@marcphilipp marcphilipp added this to the 4.13.1 milestone Oct 11, 2020
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants