Add test target to build.xml #240

Merged
merged 4 commits into from Jun 27, 2011

Conversation

Projects
None yet
2 participants
@kcooney
Member

kcooney commented Jun 1, 2011

No description provided.

@kcooney

This comment has been minimized.

Show comment Hide comment
@kcooney

kcooney Jun 1, 2011

Member

I recommend passing --no-ff when to "git merge"

Member

kcooney commented Jun 1, 2011

I recommend passing --no-ff when to "git merge"

@dsaff

View changes

build.xml
+ <jvmarg value="-Dignore.this=ignored" />
+ </run-tests>
+ </target>
+
<target name="dist" depends="populate-dist">

This comment has been minimized.

Show comment Hide comment
@dsaff

dsaff Jun 1, 2011

Owner

Can you make "dist" depend on "test", then, to remove duplication? Thanks.

@dsaff

dsaff Jun 1, 2011

Owner

Can you make "dist" depend on "test", then, to remove duplication? Thanks.

This comment has been minimized.

Show comment Hide comment
@kcooney

kcooney Jun 6, 2011

Member

I want "test" to be fast, so I want it to run the tests without doing a clean or building the jars. I had to clean it up a bit to get it to work (I think I originally tested it by doing a "dist" first).

If you are comfortable with "dist" and "profile" not using the built jars, then I can share the code.

@kcooney

kcooney Jun 6, 2011

Member

I want "test" to be fast, so I want it to run the tests without doing a clean or building the jars. I had to clean it up a bit to get it to work (I think I originally tested it by doing a "dist" first).

If you are comfortable with "dist" and "profile" not using the built jars, then I can share the code.

This comment has been minimized.

Show comment Hide comment
@kcooney

kcooney Jun 7, 2011

Member

The other option would be to always use the jars when running the tests; jar'ing the classes is reasonably fast. I just don't want to clean or build javadoc just to run the tests

@kcooney

kcooney Jun 7, 2011

Member

The other option would be to always use the jars when running the tests; jar'ing the classes is reasonably fast. I just don't want to clean or build javadoc just to run the tests

@dsaff

This comment has been minimized.

Show comment Hide comment
@dsaff

dsaff Jun 8, 2011

Owner

This works for me. Thanks.

Owner

dsaff commented Jun 8, 2011

This works for me. Thanks.

@dsaff

This comment has been minimized.

Show comment Hide comment
@dsaff

dsaff Jun 24, 2011

Owner

Can you please add a line to acknowledgements.txt? Thanks.

Owner

dsaff commented Jun 24, 2011

Can you please add a line to acknowledgements.txt? Thanks.

@kcooney

This comment has been minimized.

Show comment Hide comment
@kcooney

kcooney Jun 25, 2011

Member

Don't worry about it (you did half the work, if you remember)

Member

kcooney commented Jun 25, 2011

Don't worry about it (you did half the work, if you remember)

@dsaff

This comment has been minimized.

Show comment Hide comment
@dsaff

dsaff Jun 27, 2011

Owner

Usually, I'm a stickler for acknowledgements.txt, which doubles as thanks to the many contributors, and also a record that survives past source-control changes of contributors for licensing/legal reasons. However, since you're already well on the hook, no need.

Owner

dsaff commented Jun 27, 2011

Usually, I'm a stickler for acknowledgements.txt, which doubles as thanks to the many contributors, and also a record that survives past source-control changes of contributors for licensing/legal reasons. However, since you're already well on the hook, no need.

dsaff added a commit that referenced this pull request Jun 27, 2011

Merge pull request #240 from kcooney/ant-test
Add test target to build.xml

@dsaff dsaff merged commit 8ddf4be into junit-team:master Jun 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment