New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt 2: Setting up for resolving issue 64, Theories honoring generic t #256

Merged
merged 3 commits into from Jul 12, 2011

Conversation

Projects
None yet
3 participants
@pholser
Copy link
Contributor

pholser commented Jul 9, 2011

Attempt 2: Setting up for resolving issue 64, Theories honoring generic type parameters. This commit comprises only those changes required in the core of JUnit -- basically adding a validator that the Theories runner can call to reject theories with generic type variables (that are hard to resolve), and deprecating FrameworkMethod#producesType, which only the Theories runner uses, and which will be supplanted by an equivalent method on ParameterSignature. Other required changes will be added to the Theories experiment once it migrates over to junit.contrib.

pholser added some commits Jul 6, 2011

Attempt 2: Setting up for resolving issue 64, Theories honoring gener…
…ic type parameters. This commit comprises only those changes required in the core of JUnit -- basically adding a validator that the Theories runner can call to reject theories with generic type variables (that are hard to resolve), and deprecating FrameworkMethod#producesType, which only the Theories runner uses, and which will be supplanted by an equivalent method on ParameterSignature. Other required changes will be added to the Theories experiment once it migrates over to junit.contrib.
Adding additional javadoc context for deprecated FrameworkMethod#prod…
…ucesType. Adding acknowledgements entry for pholser. Starting 4.9.1 release notes.
@@ -0,0 +1,14 @@
## Summary of Changes in version 4.9 [unreleased!] ##

This comment has been minimized.

@dsaff

dsaff Jul 12, 2011

Member

4.9.1, please. :-)

@dsaff

This comment has been minimized.

Copy link
Member

dsaff commented Jul 12, 2011

Excellent. Just the one fix (version number in release notes), and we're finally ready to go.

@pholser

This comment has been minimized.

Copy link
Contributor

pholser commented Jul 12, 2011

There we are. Thanks for your patience!

dsaff added a commit that referenced this pull request Jul 12, 2011

Merge pull request #256 from pholser/pholser-4.9.1
Disable theories with generic type parameters in core Theories runner.

@dsaff dsaff merged commit d94d5c8 into junit-team:4.9.1 Jul 12, 2011

@dsaff

This comment has been minimized.

Copy link
Member

dsaff commented Jul 12, 2011

Au contraire, thank you!

@avandeursen

This comment has been minimized.

Copy link
Contributor

avandeursen commented Dec 11, 2012

I was running a little coverage analysis of all of JUnit, and it turns out the class NoGenericTypeParametersValidator provided in this pull request is never used.

The reason for that is that the test class provided in the pull request, WithUnresolvedGenericTypeVariablesOnTheoryParms, is not included in any suite.

The most logical solution seems adding it to the org.junit.tests.experimental.ExperimentalTests suite.

Doing that shows that the new tests fail. The reason for this is that the method FrameworkMethod.validateNoTypeParametersOnArgs(...) is never called.

Could it be that some code was missing in the pull request?

@dsaff

This comment has been minimized.

Copy link
Member

dsaff commented Dec 12, 2012

Hmm. @pholser, any thoughts?

@pholser

This comment has been minimized.

Copy link
Contributor

pholser commented Dec 12, 2012

Happy to have a look.

@pholser

This comment has been minimized.

Copy link
Contributor

pholser commented Dec 12, 2012

#572 should rectify the no-generic-parms validator missing execution/test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment