Make TestExecutionSummary.Failure serializable #2082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make the
TestExecutionSummary.Failure
interface serializable.The
Throwable
andTestIdentifier
classes that are used by this interface are serializable, so it is safe to make it serializable also.The default implementation
org.junit.platform.launcher.listeners.MutableTestExecutionSummary.DefaultFailure
is also safe to make serializable as it's a simple Java Bean with these two serializable fields.I need to be able to serialize to disk the failures of a test for QuickPerf, a tool that I works on a JUnit5 implementation that allows to make rapid performance test with JUnit4 and soon 5.
As QuickPerf needs to launch a test in a separate JVM we need a way to pass the failures from one JVM to the other, and serializing them to disk is the easiest way to do it.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done