-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AssertionFailureBuilder #2972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrannen
reviewed
Jul 10, 2022
junit-jupiter-engine/src/test/java/org/junit/jupiter/api/AssertInstanceOfAssertionsTests.java
Show resolved
Hide resolved
marcphilipp
force-pushed
the
marc/2967-assertion-builder
branch
2 times, most recently
from
July 10, 2022 12:54
283916f
to
17d4144
Compare
marcphilipp
force-pushed
the
marc/2967-assertion-builder
branch
from
July 10, 2022 13:15
17d4144
to
946f531
Compare
marcphilipp
force-pushed
the
marc/2967-assertion-builder
branch
from
July 10, 2022 13:23
02a7209
to
25d37ad
Compare
marcphilipp
changed the title
[WIP] Introduce AssertionBuilder
Introduce AssertionFailureBuilder
Jul 10, 2022
1 task
sbrannen
approved these changes
Jul 10, 2022
mamadaliev
approved these changes
Jul 13, 2022
bechte
reviewed
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two questions, most likely the missing calls to cause
should be added. Otherwise, I approve this PR.
junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertThrowsExactly.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #2967.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations