Add support for additional configuration parameters #9
Conversation
marcphilipp
force-pushed
the
marc/8-config-params
branch
2 times, most recently
from
db60ef9 to
69ba89c
Compare
README.adoc
Outdated
| maximum number of threads to use for running data providers in parallel, if enabled via `@DataProvider(parallel = true)` (default: `10`) | ||
| + | ||
| `testng.parallel` (methods|tests|classes|instances|none):: | ||
| TestNG's parallel execution mode for running tests in separate threads (default: `"none"`) |
There was a problem hiding this comment.
does Test Distribution support all of these - or if none is set, it will only disable TestNG's parallelism (as stated), but keep TDs?
There was a problem hiding this comment.
This is only about the parallelism within a partition which will still be supported (similar to Spock's or Jupiter's parallelims support).
README.adoc
Outdated
| TestNG's parallel execution mode for running tests in separate threads (default: `"none"`) | ||
| + | ||
| `testng.preserveOrder` (boolean):: | ||
| whether classes and methods should be run in a predictable order (default: `true`) |
There was a problem hiding this comment.
They would still be executed in the order TD passes them to TestNG when this flag is used.
README.adoc
Outdated
| whether classes and methods should be run in a predictable order (default: `true`) | ||
| + | ||
| `testng.threadCount` (integer):: | ||
| maximum number of threads for running tests in parallel, if enabled via `testng.parallel` (default: `5`) |
There was a problem hiding this comment.
what's the relation between this and dataProviderThreadCount?
There was a problem hiding this comment.
It's unrelated as far as I could tell.
| `testng.listeners` (comma-separated list of fully-qualified class names):: | ||
| custom listeners that should be registered when executing tests (default: `""`) | ||
| + | ||
| `testng.outputDirectory` (file path):: |
There was a problem hiding this comment.
No, not necessarily.
There was a problem hiding this comment.
shouldn't we define the base for relative paths in that case?
There was a problem hiding this comment.
I think using the working dir as a base is fine.
README.adoc
Outdated
| + | ||
| `testng.verbose` (integer):: | ||
| TestNG's level of verbosity (default: 0) | ||
| TestNG's level of verbosity (default: `0`) |
There was a problem hiding this comment.
should we add a link here describing what the level means - or add some description such as:
The verbosity level is between 0 and 10 where 10 is the most detailed. You can specify -1 and this will put TestNG in debug mode (no longer slicing off stack traces and all).
There was a problem hiding this comment.
I added a links to the most relevant sections in the TestNG docs to each config param now.
src/testFixtures/java/example/configparams/DataProviderThreadCountTestCase.java
Outdated
Show resolved
Hide resolved
src/testFixtures/java/example/configparams/InvocationTrackingListener.java
Outdated
Show resolved
Hide resolved
src/test/java/org/junit/support/testng/engine/ConfigurationParametersIntegrationTests.java
Outdated
Show resolved
Hide resolved
marcphilipp
force-pushed
the
marc/8-config-params
branch
from
69ba89c to
e11de25
Compare
Resolves #8.