From 7aa75bc108d3fee8077b07160bf3c3f8b9274820 Mon Sep 17 00:00:00 2001 From: ravowlga123 Date: Thu, 9 Jan 2020 22:51:51 +0100 Subject: [PATCH] ZOOKEEPER-3649: Add a line break in ls -s CLI As per the ticket [ZOOKEEEPER-3649](https://issues.apache.org/jira/browse/ZOOKEEPER-3649) we need to add line break ls -s command. To achieve the desired behavior I have added new line character in option.add of LsCommand.printChildren(). Please do let me know if made changes gives us the desired behavior or if anything else needs to be changed. Author: ravowlga123 Reviewers: eolivelli@apache.org, andor@apache.org Closes #1183 from ravowlga123/ZOOKEEPER-3649 and squashes the following commits: f2e1997d6 [ravowlga123] ZOOKEEPER-3649 Removed additional new line from printChildren b36d63664 [ravowlga123] ZOOKEEPER-3649 Add a line break in ls -s CLI --- .../src/main/java/org/apache/zookeeper/cli/LsCommand.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java b/zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java index 9ac942c8407..b12a12acd46 100644 --- a/zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java +++ b/zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java @@ -127,11 +127,10 @@ private void printChildren(List children, Stat stat) { } out.append(child); } - out.append("]"); + out.append("]\n"); if (stat != null) { new StatPrinter(out).print(stat); } - out.append("\n"); } }