Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final keyword #144

Merged
merged 4 commits into from Feb 27, 2018

Conversation

@Spomky
Copy link
Contributor

commented Feb 23, 2018

This PR is a proposal to fix #129.

Spomky added 2 commits Feb 23, 2018
README.md Outdated
public function getColor();
}

final class Car interface Vehicule

This comment has been minimized.

Copy link
@mikemand

mikemand Feb 23, 2018

This should be final class Car implements Vehicule, right? And Vehicle doesn't have an extra U before the l.

This comment has been minimized.

Copy link
@Spomky

Spomky Feb 23, 2018

Author Contributor

Correct

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator

commented Feb 26, 2018

Like it, clear, short and right to the point 👍 Thank you for your contribution.

Could you also link this post: https://ocramius.github.io/blog/when-to-declare-classes-final/ which explains all in more detailed way (if sb would be curious)?

@Spomky

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2018

Hi @TomasVotruba,

I've just added the reference as suggested.

Regards.

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2018

Thank you 👍

@TomasVotruba TomasVotruba merged commit 583523f into jupeter:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.