From 9399ac812121d11be77c23e1075e7ab4bd94fd7b Mon Sep 17 00:00:00 2001 From: Gregor Jasny Date: Sun, 28 Oct 2018 11:35:54 +0100 Subject: [PATCH] Prefer EXPECT_EQ/GT over EXPECT_THAT --- core/tests/family_test.cc | 5 ++--- core/tests/gauge_test.cc | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/tests/family_test.cc b/core/tests/family_test.cc index 3375245a..ab0e24e0 100644 --- a/core/tests/family_test.cc +++ b/core/tests/family_test.cc @@ -32,7 +32,7 @@ TEST(FamilyTest, counter_value) { auto collected = family.Collect(); ASSERT_GE(collected.size(), 1); ASSERT_GE(collected[0].metric.size(), 1); - EXPECT_THAT(collected[0].metric.at(0).counter.value, ::testing::Eq(1)); + EXPECT_EQ(1, collected[0].metric.at(0).counter.value); } TEST(FamilyTest, remove) { @@ -53,8 +53,7 @@ TEST(FamilyTest, Histogram) { auto collected = family.Collect(); ASSERT_EQ(collected.size(), 1); ASSERT_GE(collected[0].metric.size(), 1); - EXPECT_THAT(collected[0].metric.at(0).histogram.sample_count, - ::testing::Eq(1)); + EXPECT_EQ(1, collected[0].metric.at(0).histogram.sample_count); } TEST(FamilyTest, add_twice) { diff --git a/core/tests/gauge_test.cc b/core/tests/gauge_test.cc index 30dd47e0..fdcd34bf 100644 --- a/core/tests/gauge_test.cc +++ b/core/tests/gauge_test.cc @@ -61,7 +61,7 @@ TEST(GaugeTest, set_multiple) { TEST(GaugeTest, set_to_current_time) { Gauge gauge; gauge.SetToCurrentTime(); - EXPECT_THAT(gauge.Value(), ::testing::Gt(0.0)); + EXPECT_GT(gauge.Value(), 0.0); } } // namespace