Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of R languageserver #463

Merged
merged 3 commits into from Jan 9, 2021
Merged

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jan 9, 2021

References

Fixes #97

Code changes

  • add is_installed() for ShellSpec
  • remove R script helper, use in-line command; allows to add specs for potential forks of languagesever easily (and test easily)
  • adapt is_installed_args for Rlanguageserver spec
  • do not start the R language server in debug mode by default any longer (reduces clutter in the console) as it works reliably well recently
  • fix links in the docs to JupyterLab docs
  • explain what we mean by shell token in the docs

User-facing changes

R language server will be correctly detected as absent if not installed in the current R environment.

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski merged commit 0102d5a into master Jan 9, 2021
@krassowski krassowski deleted the autodetect-r-langserver branch July 25, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R language server reported as available even when language server package is missing (but R is installed)
1 participant