Skip to content

Limits maximum size of compute type dropdown #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2022
Merged

Limits maximum size of compute type dropdown #183

merged 2 commits into from
Oct 22, 2022

Conversation

@JasonWeill
Copy link
Collaborator

Partial fix for #177. Prevents compute type dropdown from taking over nearly the full height of the viewport.

Compute type with no max-height:

image

Compute type with a 20em max-height:

image

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/limited-select-height

@JasonWeill JasonWeill mentioned this pull request Oct 22, 2022
Closed
5 tasks
@dlqqq dlqqq added the enhancement New feature or request label Oct 22, 2022
@JasonWeill JasonWeill merged commit 15ad1c1 into jupyter-server:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrii-i andrii-i andrii-i approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JasonWeill @andrii-i @dlqqq