Select all output formats by default #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andrii-i
force-pushed
the
default-select-all-output-formats
branch
from
27282c2 to
f4a21d2
Compare
andrii-i
changed the title
andrii-i
changed the title
dlqqq
requested changes
Oct 25, 2022
|
Updated preview in the PR description |
dlqqq
approved these changes
Oct 25, 2022
|
I'm particularly happy that if-else branching in useEffect is not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Takes care of "select all output formats by default" part of #196
"Allow for selection of no formats" would be taken care of in a separate PR
Preview