Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of check manifest #392

Merged

Conversation

blink1073
Copy link
Contributor

Fixes #335 and a bug in the last release.

@blink1073 blink1073 added the bug Something isn't working label Sep 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 82.51% // Head: 82.40% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (18a0f43) compared to base (db21e02).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   82.51%   82.40%   -0.11%     
==========================================
  Files          21       21              
  Lines        2899     2905       +6     
  Branches      380      382       +2     
==========================================
+ Hits         2392     2394       +2     
- Misses        373      376       +3     
- Partials      134      135       +1     
Impacted Files Coverage Δ
jupyter_releaser/cli.py 88.74% <33.33%> (-1.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 0146419 into jupyter-server:main Sep 20, 2022
@blink1073 blink1073 deleted the fix-check-manifest-handling branch September 20, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Check-Manifest if the build backend is not Setuptools
2 participants