From 03aef7d0be694cf0d4fd574c4cadb3a32c519619 Mon Sep 17 00:00:00 2001 From: Vishwajeet Verma Date: Mon, 31 Jan 2022 13:02:20 +0530 Subject: [PATCH 1/2] Fix to add session only after kernel validation --- jupyter_server/services/kernels/handlers.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jupyter_server/services/kernels/handlers.py b/jupyter_server/services/kernels/handlers.py index 46b54b937..822df1d1d 100644 --- a/jupyter_server/services/kernels/handlers.py +++ b/jupyter_server/services/kernels/handlers.py @@ -387,7 +387,8 @@ async def _register_session(self): if stale_handler: self.log.warning("Replacing stale connection: %s", self.session_key) await stale_handler.close() - self._open_sessions[self.session_key] = self + if self.kernel_id in self.kernel_manager: # only update open sessions if kernel is actively managed + self._open_sessions[self.session_key] = self def open(self, kernel_id): super(ZMQChannelsHandler, self).open() From 9b4f3c76b81c0cc791a909bac6016c5dbc47a0a3 Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Mon, 31 Jan 2022 08:10:22 -0600 Subject: [PATCH 2/2] lint --- jupyter_server/services/kernels/handlers.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/jupyter_server/services/kernels/handlers.py b/jupyter_server/services/kernels/handlers.py index 822df1d1d..df7df529f 100644 --- a/jupyter_server/services/kernels/handlers.py +++ b/jupyter_server/services/kernels/handlers.py @@ -387,7 +387,9 @@ async def _register_session(self): if stale_handler: self.log.warning("Replacing stale connection: %s", self.session_key) await stale_handler.close() - if self.kernel_id in self.kernel_manager: # only update open sessions if kernel is actively managed + if ( + self.kernel_id in self.kernel_manager + ): # only update open sessions if kernel is actively managed self._open_sessions[self.session_key] = self def open(self, kernel_id):