Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo-detection code for jupyterlab_widgets #3090

Closed
jasongrout opened this issue Feb 5, 2021 · 0 comments · Fixed by #3119
Closed

Update repo-detection code for jupyterlab_widgets #3090

jasongrout opened this issue Feb 5, 2021 · 0 comments · Fixed by #3119
Assignees
Milestone

Comments

@jasongrout
Copy link
Member

We have some code (that actually doesn't work, I think?) at

# if the static assets already exist, do not invoke npm so we can make a wheel
# from the sdist package, since the npm build really only works from this
# repo.
jsbuild = []
if all(os.path.exists(f) for f in jstargets):
jsbuild.append(install_npm(HERE, build_cmd="build:prod", npm=["jlpm"]))
jsbuild.append(ensure_targets(jstargets))
cmdclass["jsdeps"] = combine_commands(*jsbuild)
(and soon in master after #3086) to detect if we are building jupyterlab_widgets in the repo, to avoid recompiling js files many times.

The updated jlab extension cookiecutter has better code at

https://github.com/jupyterlab/extension-cookiecutter-ts/blob/b13df389efd10fbccba441537aa198e64f623fa4/%7B%7Bcookiecutter.python_name%7D%7D/setup.py#L53-L57

I think we should switch our code to using code like is currently in the jlab extension cookiecutter.

@jasongrout jasongrout added this to the 8.0 milestone Feb 5, 2021
@jasongrout jasongrout self-assigned this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant