Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select boxes to respond to setting the height. #1250

Merged
merged 1 commit into from Apr 4, 2017

Conversation

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Apr 4, 2017

Fixes #1240.

There still is a small issue - setting height to inherit actually makes the listbox extend below the control just a bit when the height is set (because of the margin on the control itself). It extends only about as much as the top margin, though. Presumably this can be corrected with a calc() dynamic css property. I'm open to better ways to correct it, though!

Fixes jupyter-widgets#1240.

There still is a small issue - setting height to inherit actually makes the listbox extend below the control just a bit (because the margin on the control itself).
@jasongrout jasongrout merged commit 2e77da4 into jupyter-widgets:master Apr 4, 2017
1 check passed
Loading
@jasongrout jasongrout added this to the 7.0 milestone Apr 11, 2017
@jasongrout jasongrout added this to the 7.0 milestone Apr 11, 2017
@jasongrout jasongrout mentioned this pull request Apr 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant