Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make widgets render using output areas in classic notebook. #1274

Merged
merged 20 commits into from Apr 18, 2017
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Use the view.cid unique id as an identifying id.

  • Loading branch information...
jasongrout committed Apr 13, 2017
commit 17b7ae7a5caa9e14d12c38fb800dbef888288aae
@@ -48,6 +48,10 @@ function register_events(Jupyter, events, outputarea) {
handle_kernel(Jupyter, data.kernel);
});

/**
* The views on this page. We keep this list so that we can call the view.remove()
* method when a view is removed from the page.
*/
var views = {};
var removeView = function(event, data) {
var output = data.cell.output_area;
@@ -90,9 +94,10 @@ function register_events(Jupyter, events, outputarea) {
model.then(function(model) {
return manager.display_model(void 0, model, void 0);
}).then(function(view) {
var id = view.cid;
output._jupyterWidgetViews = output._jupyterWidgetViews || [];
output._jupyterWidgetViews.push(view.id);
views[view.id] = view;
output._jupyterWidgetViews.push(id);
views[id] = view;
PhosphorWidget.Widget.attach(view.pWidget, node);
});
} else {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.