New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox, RadioButton, and spacing functionality/ux improvements #1346

Merged
merged 4 commits into from May 15, 2017

Conversation

Projects
None yet
2 participants
@maxnoy
Contributor

maxnoy commented May 11, 2017

  • Checkbox description on the right
  • Checkbox indent
  • Improved spacing between description and widgets
  • Reduce spacing between radio buttons

@maxnoy maxnoy force-pushed the maxnoy:checkboxplus branch from 901b831 to f74d4ad May 12, 2017

@maxnoy maxnoy changed the title from Checkbox descriptions are clickable and on the right, improved spacing for radios and descriptions to Checkbox descriptions are clickable and on the right, improved spacing for radios and descriptions, radio widgets size is multiple of single widget, radio widget handling of zero options fixed May 12, 2017

@maxnoy maxnoy changed the title from Checkbox descriptions are clickable and on the right, improved spacing for radios and descriptions, radio widgets size is multiple of single widget, radio widget handling of zero options fixed to Checkbox, RadioButton, and spacing functionality/ux improvements May 12, 2017

@maxnoy

This comment has been minimized.

Contributor

maxnoy commented May 12, 2017

Changes:

  • Checkbox descriptions are clickable and on the right
  • Reduced spacing between radiobutton options
  • RadioButton widget autosizes to a multiple of single-line widgets to still line up properly
  • Doubled margin between descriptions and widgets
  • Checkboxes and RadioButtons are now aligned properly vertically with other widget controls
  • RadioButton widget fix for when options are reset to empty list
@maxnoy

This comment has been minimized.

Contributor

maxnoy commented May 12, 2017

Before
ipw1-before

After
ipw1-after

After -- showing horizontal alignment
ipw1-afteraligned

@jasongrout

This comment has been minimized.

Member

jasongrout commented May 12, 2017

Do you think this is ready to review/merge?

@jasongrout

This comment has been minimized.

Member

jasongrout commented May 12, 2017

Also, this fixes #237.

@maxnoy

This comment has been minimized.

Contributor

maxnoy commented May 12, 2017

@jasongrout, I believe so.

@jasongrout

This comment has been minimized.

Member

jasongrout commented May 12, 2017

Awesome! I won't be able to look at this again until Monday - @maartenbreddels or @SylvainCorlay, feel free to review and merge this before then if you want. Otherwise I'll take it back up Monday.

Thanks @maxnoy! It looks and functions way, way better.

@maxnoy

This comment has been minimized.

Contributor

maxnoy commented May 12, 2017

Thank you again @jasongrout!!

@jasongrout

This comment has been minimized.

Member

jasongrout commented May 15, 2017

Tested this out, and it seems to work great. Thanks!

@jasongrout jasongrout merged commit 14bfd0b into jupyter-widgets:master May 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasongrout jasongrout modified the milestone: 7.0 May 15, 2017

@maxnoy

This comment has been minimized.

Contributor

maxnoy commented May 15, 2017

Thanks @jasongrout!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment