Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox, RadioButton, and spacing functionality/ux improvements #1346

Merged
merged 4 commits into from May 15, 2017

Conversation

@maxnoy
Copy link
Contributor

@maxnoy maxnoy commented May 11, 2017

  • Checkbox description on the right
  • Checkbox indent
  • Improved spacing between description and widgets
  • Reduce spacing between radio buttons
@maxnoy maxnoy changed the title Checkbox descriptions are clickable and on the right, improved spacing for radios and descriptions Checkbox descriptions are clickable and on the right, improved spacing for radios and descriptions, radio widgets size is multiple of single widget, radio widget handling of zero options fixed May 12, 2017
@maxnoy maxnoy changed the title Checkbox descriptions are clickable and on the right, improved spacing for radios and descriptions, radio widgets size is multiple of single widget, radio widget handling of zero options fixed Checkbox, RadioButton, and spacing functionality/ux improvements May 12, 2017
@maxnoy
Copy link
Contributor Author

@maxnoy maxnoy commented May 12, 2017

Changes:

  • Checkbox descriptions are clickable and on the right
  • Reduced spacing between radiobutton options
  • RadioButton widget autosizes to a multiple of single-line widgets to still line up properly
  • Doubled margin between descriptions and widgets
  • Checkboxes and RadioButtons are now aligned properly vertically with other widget controls
  • RadioButton widget fix for when options are reset to empty list

Loading

@maxnoy
Copy link
Contributor Author

@maxnoy maxnoy commented May 12, 2017

Before
ipw1-before

After
ipw1-after

After -- showing horizontal alignment
ipw1-afteraligned

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented May 12, 2017

Do you think this is ready to review/merge?

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented May 12, 2017

Also, this fixes #237.

Loading

@maxnoy
Copy link
Contributor Author

@maxnoy maxnoy commented May 12, 2017

@jasongrout, I believe so.

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented May 12, 2017

Awesome! I won't be able to look at this again until Monday - @maartenbreddels or @SylvainCorlay, feel free to review and merge this before then if you want. Otherwise I'll take it back up Monday.

Thanks @maxnoy! It looks and functions way, way better.

Loading

@maxnoy
Copy link
Contributor Author

@maxnoy maxnoy commented May 12, 2017

Thank you again @jasongrout!!

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented May 15, 2017

Tested this out, and it seems to work great. Thanks!

Loading

@jasongrout jasongrout merged commit 14bfd0b into jupyter-widgets:master May 15, 2017
1 check passed
Loading
@jasongrout jasongrout added this to the 7.0 milestone May 15, 2017
@jasongrout jasongrout added this to the 7.0 milestone May 15, 2017
@maxnoy
Copy link
Contributor Author

@maxnoy maxnoy commented May 15, 2017

Thanks @jasongrout!!

Loading

@jasongrout jasongrout mentioned this pull request May 16, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants