Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Export output widget in embed bundle #1410
Prior to this PR, the output widget could not be embedded. Addresses issue #986 .
This is a rewrite of PR #1380, which had become out of date after the htmlmanager was moved to a stand-alone package.
I think this still needs:
referenced this pull request
Jun 5, 2017
@jasongrout I'm about to start work on letting users override renderers in the HTML Manager. How were you thinking users would hook into this?
One way would be to define a top-level method in
Alternatively, we could just expose the options as an extra argument to
I think I'm mildly in favour of the second option, since it exposes less magic.
IIRC, a top-level method won't work since you might have multiple instances of the widget manager on a single page - I think this may happen in some of the documentation scenarios.
Since your rendermime instance is exposed as a public attribute on the manager (i.e., the manager's rendermime is what is passed to the output widget), I think that may be enough - people can access the rendermime directly and add other renderers as needed.