Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the value assigned to a selection .options attribute #1513

Merged
merged 2 commits into from Jul 18, 2017

Conversation

@jasongrout
Copy link
Member

commented Jul 18, 2017

We also re-architect the code a bit to make the inheritance cleaner.

Fixes #1512

jasongrout added some commits Jul 18, 2017

Preserve the value assigned to a selection .options attribute
We also re-architect the code a bit to make the inheritance cleaner.

Fixes #1512

@jasongrout jasongrout force-pushed the jasongrout:selectoptions branch from 6fffb80 to d4e5549 Jul 18, 2017

@jasongrout jasongrout merged commit 587b1b6 into jupyter-widgets:master Jul 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasongrout jasongrout modified the milestone: 7.0 Jul 18, 2017

jasongrout added a commit to jasongrout/ipywidgets that referenced this pull request Jul 18, 2017

Fix a regression in jupyter-widgets#1513 with creating selection rang…
…e sliders.

The following was broken:

from ipywidgets import SelectionRangeSlider
s=SelectionRangeSlider(options=[1])

jasongrout added a commit to jasongrout/ipywidgets that referenced this pull request Jul 18, 2017

Fix a regression in jupyter-widgets#1513 with creating selection rang…
…e sliders.

The following was broken:

from ipywidgets import SelectionRangeSlider
s=SelectionRangeSlider(options=[1])

jasongrout added a commit that referenced this pull request Jul 18, 2017

Merge pull request #1514 from jasongrout/multiselect
Fix a regression in #1513 with creating selection range sliders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.