New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat embed amd files together to have one file to include #1630

Merged
merged 4 commits into from Aug 15, 2017

Conversation

Projects
None yet
1 participant
@jasongrout
Member

jasongrout commented Aug 15, 2017

This concatentates all of the amd embedding scripts together so that we just have one file to include as a script tag. This ensures that there is only one request, and that all of the version numbers are consistent.

Now a custom widget embedding just requires:

<script src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.js" integrity="sha256-zPseknSmTN790o9fjoPFR/gHHmF2APMkKLgHke4RTM4=" crossorigin="anonymous"></script>
<script src="https://unpkg.com/@jupyter-widgets/html-manager/dist/embed-amd.js"></script>

jasongrout added some commits Aug 15, 2017

@jasongrout jasongrout added this to the 7.0 milestone Aug 15, 2017

@jasongrout jasongrout merged commit f832983 into jupyter-widgets:master Aug 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jasongrout

This comment has been minimized.

Member

jasongrout commented Aug 15, 2017

maartenbreddels added a commit to maartenbreddels/ipywidgets that referenced this pull request Aug 15, 2017

maartenbreddels added a commit to maartenbreddels/jupyter-sphinx that referenced this pull request Aug 15, 2017

SylvainCorlay added a commit to jupyter-widgets/jupyter-sphinx that referenced this pull request Nov 30, 2017

works with ipywidgets7rc0 (#16)
* bumped version to force install on rtd

* bumped version to force install on rtd, take 2

* added require

* fix: for ipywidgets7

* following jupyter-widgets/ipywidgets#1629

* fix in import and ipywidgets6 support

* following up jupyter-widgets/ipywidgets#1630

* missing newline

* now using conf.py config values for more flexibility

* mention that the extra configuration options are optional

* removed print statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment