Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for notebook 5.3 you don't need to enable the extensions anymore, solves #1908 #1911

Merged
merged 3 commits into from Jan 17, 2018

Conversation

@maartenbreddels
Copy link
Member

@maartenbreddels maartenbreddels commented Jan 17, 2018

for notebook 5.3 you don't need to enable the extensions anymore, solves #1908

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jan 17, 2018

For backwards compatibility, it's actually:

{
  "load_extensions": {
    "jupyter-js-widgets/extension": true
  }
}

Loading

@maartenbreddels
Copy link
Member Author

@maartenbreddels maartenbreddels commented Jan 17, 2018

good catch 👍

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jan 17, 2018

Thanks. Came from trying it out and seeing it didn't work :).

Loading

@maartenbreddels
Copy link
Member Author

@maartenbreddels maartenbreddels commented Jan 17, 2018

After the third widget I got a bit overconfident :)

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jan 17, 2018

There be dragons in this ancient codebase!

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jan 17, 2018

This works great. Thanks!

Loading

@jasongrout jasongrout merged commit 7626dc8 into jupyter-widgets:master Jan 17, 2018
1 check passed
Loading
@jasongrout jasongrout added this to the Patch release milestone Jan 17, 2018
@jasongrout jasongrout removed this from the Patch release milestone Mar 19, 2018
@jasongrout jasongrout added this to the 7.2 milestone Mar 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants