New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export link and dlink from traitlets for consistency with the javascript api #1923

Merged
merged 2 commits into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@rprimet

rprimet commented Jan 23, 2018

…script API

@rprimet

This comment has been minimized.

rprimet commented Jan 23, 2018

(related issue: #1809)

@jasongrout

This comment has been minimized.

Member

jasongrout commented Jan 24, 2018

Thank you! Can we also delete the cell in the example where traitlets is imported?

@jasongrout jasongrout changed the title from re-export link and dlink from traitlets for consistency with the java… to re-export link and dlink from traitlets for consistency with the javascript api Jan 24, 2018

@jasongrout jasongrout added this to the Minor release milestone Jan 24, 2018

@rprimet

This comment has been minimized.

rprimet commented Jan 24, 2018

Good catch, thanks! This should be fixed now.

@jasongrout

This comment has been minimized.

Member

jasongrout commented Jan 25, 2018

Thank you!

@jasongrout jasongrout merged commit 648dd00 into jupyter-widgets:master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rprimet rprimet deleted the rprimet:link_export branch Jan 25, 2018

@SylvainCorlay

This comment has been minimized.

Member

SylvainCorlay commented Jan 30, 2018

Quick note @rprimet, your git configuration does not match your GitHub user email so that your account is not credited with this commit. Sorry for not catching that earlier.

@rprimet

This comment has been minimized.

rprimet commented Jan 30, 2018

Ah thanks for that ! I'll update my git config.

@jasongrout jasongrout modified the milestones: Minor release, 7.2 Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment