Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export link and dlink from traitlets for consistency with the javascript api #1923

Merged
merged 2 commits into from Jan 25, 2018

Conversation

@rprimet
Copy link

@rprimet rprimet commented Jan 23, 2018

…script API

@rprimet
Copy link
Author

@rprimet rprimet commented Jan 23, 2018

(related issue: #1809)

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jan 24, 2018

Thank you! Can we also delete the cell in the example where traitlets is imported?

Loading

@jasongrout jasongrout changed the title re-export link and dlink from traitlets for consistency with the java… re-export link and dlink from traitlets for consistency with the javascript api Jan 24, 2018
@jasongrout jasongrout added this to the Minor release milestone Jan 24, 2018
@rprimet
Copy link
Author

@rprimet rprimet commented Jan 24, 2018

Good catch, thanks! This should be fixed now.

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jan 25, 2018

Thank you!

Loading

@jasongrout jasongrout merged commit 648dd00 into jupyter-widgets:master Jan 25, 2018
1 check passed
Loading
@rprimet rprimet deleted the link_export branch Jan 25, 2018
@SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Jan 30, 2018

Quick note @rprimet, your git configuration does not match your GitHub user email so that your account is not credited with this commit. Sorry for not catching that earlier.

Loading

@rprimet
Copy link
Author

@rprimet rprimet commented Jan 30, 2018

Ah thanks for that ! I'll update my git config.

Loading

@jasongrout jasongrout removed this from the Minor release milestone Mar 19, 2018
@jasongrout jasongrout added this to the 7.2 milestone Mar 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants