Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package license files #2048

Closed
wants to merge 3 commits into from
Closed

Conversation

@jakirkham
Copy link

@jakirkham jakirkham commented Apr 16, 2018

Make sure the license files get included in the various sdists.

jakirkham and others added 3 commits Apr 16, 2018
Make sure `COPYING.md` and `LICENSE` are in the `sdist`.
Make sure the `LICENSE` is included in `sdist`s.
Appears that referencing the higher level directory does not work with
`MANIFEST.in`.

ref: https://stackoverflow.com/a/27651742
@jasongrout
Copy link
Member

@jasongrout jasongrout commented Apr 16, 2018

Thanks!

Loading

@jakirkham
Copy link
Author

@jakirkham jakirkham commented Apr 27, 2018

Anything else?

Loading

@jasongrout
Copy link
Member

@jasongrout jasongrout commented Apr 27, 2018

Sorry, I've been busy with JupyterLab lately. Looking at this more closely, perhaps we should solve #1701 first to clear up the confusion rather than propagating it into the packages. Let me look at that first (e.g., #1706)

Loading

@jasongrout jasongrout added this to the 7.3 milestone Jul 6, 2018
jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Jul 16, 2018
Based on discussion at jupyter/governance#37 and discussion from the links on that issue, I made the following changes:

1. Delete the COPYING.md, as it was redundant
2. Changed the LICENSE copyright dates to just have the starting year

I also added LICENSE to the widgetsnbextension package (thanks to @jakirkham for noticing this in jupyter-widgets#2048).

This supersedes jupyter-widgets#1706, which was reverted in master while the discussion was still happening.
@jasongrout
Copy link
Member

@jasongrout jasongrout commented Jul 17, 2018

Thanks! Fixed by #2133.

Loading

@jasongrout jasongrout closed this Jul 17, 2018
@lock lock bot added the resolved-locked label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants