Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GridBox widget #2064

Closed
wants to merge 1 commit into from

Conversation

@Madhu94
Copy link
Contributor

commented May 1, 2018

For #1942

Let me know if this looks fine, I've gone with @SylvainCorlay's suggestion.

@Madhu94 Madhu94 referenced this pull request May 9, 2018
@mlucool

This comment has been minimized.

Copy link

commented May 17, 2018

Any updates on this?

@SylvainCorlay

This comment has been minimized.

Copy link
Member

commented May 17, 2018

I plan on reviewing this next week. I am off for a couple of days.

@Madhu94

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2018

@SylvainCorlay Did you get time to check this ?

@SylvainCorlay

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

Hey @Madhu94 thanks for this. I have been looking at this yesterday with @jasongrout and have made some experiment on the top of your PR in #2107.

Basically, I am extending layout instead of adding new layout types, besides that, it is the same as what you did, plus I add content to the documentation for the grid layout. The PR includes your commits.

@jasongrout

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

Closed in favor of #2107. If this should remain open, let us know and we can reopen it.

@jasongrout jasongrout closed this Jul 6, 2018

@jasongrout jasongrout added this to the Reference milestone Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.