Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Grid layout #2107
Both commits taken together, my changes are effectively wiped out and might as well not be included ! :(
Could you please let me know what were the reasons for proposing it should be a separate class ?
Yeah, I am really sorry if you spent too much time on separating it in multiple widgets.
So I was playing with your implementation yesterday and my initial change was to group things using the shorthand properties like elsewhere in ipywidgets. Although I did not go all the way, because there is a catch-all
Then we discussed with @jasongrout and went back & forth between the initial design of adding grid properties to layout that I think you proposed and your PR.
In any case, I would be happy to squash my commit into yours especially as you pretty much had this version already earlier.
From what I gather in the original thread, you seem to lean towards a single layout attribute. Also, coming back to your proposal of having a hierarchy of
What do you think? Should we go ahead with something like this or would you like to iterate more upon it in the earlier PR?
The current state is similar to how
No, please go ahead with your changes, my apologies if the earlier comment seemed a little aggressive.