Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'transparent' as a color #2128

Merged
merged 1 commit into from Jul 10, 2018

Conversation

@mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jul 10, 2018

I believe 'transparent' is a valid HTML color (see https://developer.mozilla.org/en-US/docs/Web/CSS/color_value for documentation of transparent as a color). It would be handy in bqplot for making unfilled markers.

@SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Jul 10, 2018

Fastest merge in the west :)

Loading

@SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Jul 10, 2018

For the record:

https://developer.mozilla.org/en-US/docs/Web/CSS/color_value

The transparent keyword represents a fully transparent color. This makes the background behind the colored item completely visible. Technically, transparent is a shortcut for rgba(0,0,0,0).

Loading

@SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Jul 10, 2018

The failure on Python 3.3 is unrelated to that change and is due to Python 3.3 now being deprecated.

I am merging an opening a PR removing it from the build matrix.

Loading

@SylvainCorlay SylvainCorlay merged commit 2f3de0d into jupyter-widgets:master Jul 10, 2018
1 check failed
Loading
@jasongrout jasongrout added this to the 7.3 milestone Jul 16, 2018
@lock lock bot added the resolved-locked label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants