Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify license files. #2133

Merged
merged 2 commits into from Jul 17, 2018

Conversation

@jasongrout
Copy link
Member

commented Jul 16, 2018

Based on discussion at jupyter/governance#37 and discussion from the links on that issue, I made the following changes:

  1. Delete the COPYING.md, as it was redundant
  2. Changed the LICENSE copyright dates to just have the starting year

I also added LICENSE to the widgetsnbextension package (thanks to @jakirkham for noticing this in #2048).

This supersedes #1706, which was reverted in master while the discussion was still happening.

Clarify license files.
Based on discussion at jupyter/governance#37 and discussion from the links on that issue, I made the following changes:

1. Delete the COPYING.md, as it was redundant
2. Changed the LICENSE copyright dates to just have the starting year

I also added LICENSE to the widgetsnbextension package (thanks to @jakirkham for noticing this in #2048).

This supersedes #1706, which was reverted in master while the discussion was still happening.

@jasongrout jasongrout requested a review from SylvainCorlay Jul 16, 2018

@jasongrout

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2018

CC @SylvainCorlay, @maartenbreddels, @jakirkham. Please feel free to comment anyone else as well.

@jasongrout jasongrout added this to the 7.3 milestone Jul 16, 2018

@jasongrout jasongrout referenced this pull request Jul 16, 2018
@jakirkham

This comment has been minimized.

Copy link

commented Jul 17, 2018

Thanks @jasongrout.

Should widgetsnbextension/setup.cfg be updated as well?

@SylvainCorlay

This comment has been minimized.

Copy link
Member

commented Jul 17, 2018

This looks good to me.

@jasongrout

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

Should widgetsnbextension/setup.cfg be updated as well?

Yes, thanks. Done.

@jasongrout jasongrout merged commit a7096ca into jupyter-widgets:master Jul 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.