Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop postcss #2418

Merged
merged 2 commits into from May 24, 2019

Conversation

@SylvainCorlay
Copy link
Member

commented May 23, 2019

This makes widgetsnbextension and html-manager use the raw CSS from @jupyter-widgets/controls instead of the version processed with postcss and cssnext.

  • cssnext was substituting CSS variables with their values.
  • with this change, the CSS variables that are defined to polyfill for JupyterLab in the classic notebook become visible and usable by widgets. This will allow custom widget libraries to handle lab, classic, and embedded contexts in a more homogeneous way.
  • cssnext is deprecated.

Note: that IE does not support CSS variables, but it is not a supported browser for the classic notebook at the moment.

@SylvainCorlay SylvainCorlay force-pushed the SylvainCorlay:drop-postcss branch from f8a89ea to ac4fa99 May 23, 2019

@SylvainCorlay SylvainCorlay force-pushed the SylvainCorlay:drop-postcss branch from ac4fa99 to 15c045c May 23, 2019

@SylvainCorlay

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

@jasongrout as per our discussion.

@maartenbreddels

This comment has been minimized.

Copy link
Member

commented May 23, 2019

I see a lot of red 👍 (as in lines removed).
To summarize, instead of substituting the variables, we now include them in the controls package? Which means the become visible in the notebook once the controls package is loaded?

@SylvainCorlay

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

To summarize, instead of substituting the variables, we now include them in the controls package? Which means the become visible in the notebook once the controls package is loaded?

widgets.css includes the variables. (all it does is @import labvariables.css and @import widgtets-base.css).

@SylvainCorlay

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

@maartenbreddels @jasongrout how about we press the green button?

@jasongrout

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Reviewing this is next on my list, after a short break :)

@jasongrout

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Thanks. I'll note that we still build widgets.built.css so people can still use it from the @jupyter-widgets/controls package if they wish.

@jasongrout jasongrout merged commit 1aeb7ee into jupyter-widgets:master May 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasongrout jasongrout added this to the Minor release milestone May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.