Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when __copy__ method is used on base widget class #3780

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

mmc1718
Copy link
Contributor

@mmc1718 mmc1718 commented May 24, 2023

Base widget class does not have a copy implementation and raises a NotImplementedError.
Test case added in test_widget.py
Fixes jupyter-widgets#2352
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch mmc1718/ipywidgets/duplicating-widget

@ibdafna
Copy link
Member

ibdafna commented Jun 20, 2023

@mmc1718 Many thanks for the contribution! Would you be able to run a quick lint pass on this?

@mmc1718
Copy link
Contributor Author

mmc1718 commented Jun 20, 2023

Thanks @ibdafna, I have run prettier and yarn lint:check locally and hopefully it should pass now :)

Copy link
Member

@ibdafna ibdafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ibdafna ibdafna merged commit 689bc46 into jupyter-widgets:main Aug 15, 2023
19 checks passed
Copy link

@JennPlothow JennPlothow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants