only filter stored snapshots #591

Merged
merged 2 commits into from May 19, 2016

Conversation

Projects
None yet
3 participants
@minrk
Contributor

minrk commented May 18, 2016

don't re-render outputs on the page

This should fix the problem of js outputs being re-executed on save.

I was a bit surprised that I didn't have to remove the snapshots from the page, but I don't seem to, because they don't seem to be there when this is called.

cc @SylvainCorlay and @jdfreder for review, in case there's something else needed here.

closes #554

only filter stored snapshots
don't re-render outputs on the page
@jdfreder

This comment has been minimized.

Show comment
Hide comment
@jdfreder

jdfreder May 18, 2016

Contributor

I'm a little worried that this is a race condition, in that if ipywidgets gets loaded later the outputs will be on the page. I'll take a look though. Thanks for the PR!

Contributor

jdfreder commented May 18, 2016

I'm a little worried that this is a race condition, in that if ipywidgets gets loaded later the outputs will be on the page. I'll take a look though. Thanks for the PR!

@jdfreder

This comment has been minimized.

Show comment
Hide comment
@jdfreder

jdfreder May 18, 2016

Contributor

@minrk this does not remove the widget snapshots for me, because the widget JS is loaded after the notebook contents have already rendered on the page.

Here's a gif illustrating the order of events:
noclear

I'll take a look at this now, expect a PR to your PR soon...

Contributor

jdfreder commented May 18, 2016

@minrk this does not remove the widget snapshots for me, because the widget JS is loaded after the notebook contents have already rendered on the page.

Here's a gif illustrating the order of events:
noclear

I'll take a look at this now, expect a PR to your PR soon...

@jdfreder

This comment has been minimized.

Show comment
Hide comment
@jdfreder

jdfreder May 18, 2016

Contributor

minrk#3 😄

Contributor

jdfreder commented May 18, 2016

minrk#3 😄

@jdfreder jdfreder added this to the 5.1 milestone May 18, 2016

@jdfreder jdfreder added the backport label May 18, 2016

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk May 19, 2016

Contributor

Thanks for the extra fix, @jdfreder!

Contributor

minrk commented May 19, 2016

Thanks for the extra fix, @jdfreder!

@SylvainCorlay

This comment has been minimized.

Show comment
Hide comment
Member

SylvainCorlay commented May 19, 2016

LGTM.

@jdfreder jdfreder merged commit 2460c77 into jupyter-widgets:master May 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Carreau Carreau referenced this pull request in jupyter/notebook May 20, 2016

Open

Debug magic prompt disappears #1470

@SylvainCorlay SylvainCorlay removed the backport label May 25, 2016

@SylvainCorlay

This comment has been minimized.

Show comment
Hide comment
@SylvainCorlay

SylvainCorlay May 25, 2016

Member

backported

Member

SylvainCorlay commented May 25, 2016

backported

@minrk minrk deleted the minrk:snapshots-without-rerender branch Jun 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment