Fix off-by-one in c_format for printf() #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value of vsnprintf is the number of characters _excluding_ the null byte, while the second parameter is the maximum number of bytes that vsnprintf will write _including_ the terminating null byte.
|
In most cases, the last character is a line break so I didn't notice... |
|
Thanks! |
fengjixuchui
added a commit
to fengjixuchui/xeus-cling
that referenced
this issue
Apr 15, 2020
Merge pull request jupyter-xeus#332 from hahnjo/printf-null-byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The return value of vsnprintf is the number of characters excluding
the null byte, while the second parameter is the maximum number of
bytes that vsnprintf will write including the terminating null byte.