Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license guidelines for projects #66

Open
wants to merge 2 commits into
base: master
from

Conversation

@jasongrout
Copy link
Member

commented Sep 9, 2019

This follows up on conversation in #37 and the mailing list discussion about updating our project license and copyright terms to be more clear and conform better to the opensource.org and spdx BSD license pages.

Fixes #37

Summary of updates

  • Update primary license name to 3-Clause BSD License to reflect the opensource.org and spdx.org primary names for the license

  • Make copyright owner “Project Jupyter Contributors” to reflect discussion in the mailing list thread. We do not view this as a change, but rather as a clarification of our shared copyright model.

  • Wrap all lines to 78 or fewer characters

  • Update BSD conditions to be enumerated with numbers, following the text on opensource.org and spdx.org

  • In condition 3, replace “Jupyter Development Team” with the exact license text “copyright holder”.

  • We previously had, in the disclaimer section, a sentence starting with “IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS…”. OWNER is now replaced with HOLDER, to reflect the license text on opensource.org and spdx.org

  • Update the per-file license statement with “Project Jupyter Contributors” and “3-Clause BSD License” terminology.

I also edited our copyright policy explanation for grammar and to clarify that for a particular project, its copyright is shared by its contributors (not necessarily all Jupyter contributors).

jasongrout added 2 commits Sep 9, 2019
Update project license statement to reflect project discussion.
These changes come from discussion at #37 and on the mailing list thread https://groups.google.com/forum/#!topic/jupyter/vZpWgw8zKdc

Summary of changes:

* Update primary license name to 3-Clause BSD License to reflect the opensource.org and spdx.org primary names for the license

* Make copyright owner “Project Jupyter Contributors” to reflect discussion in the mailing list thread. We do not view this as a change, but rather as a clarification of our shared copyright model.

* Wrap all columns to 78 or fewer characters

* Update BSD conditions to be enumerated with numbers, following the text on opensource.org and spdx.org

* In condition 3, replace “Jupyter Development Team” with the exact license text “copyright holder”.

* We previously had, in the disclaimer section, a sentence starting with “IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS…”. OWNER is now replaced with HOLDER, to reflect the license text on opensource.org and spdx.org

* Update the per-file license statement with “Project Jupyter Contributors” and “3-Clause BSD License” terminology.
Update our explanatory note about our shared copyright model.
This also clarifies that for a particular project, its copyright is shared by its contributors (not necessarily *all* Jupyter contributors).
@jasongrout

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

According to governance rules, this PR needs approval by 2/3 of the steering council, with at least 80% voting, to be merged. For our current size of 17, that means at least 14 total votes and at least 12 positive votes. Count my vote as 1.

Of course community discussion is welcome as well.

@afshin
afshin approved these changes Sep 9, 2019
@jasongrout

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

And of course, comments or suggestions are also encouraged and invited, not just an up-or-down vote.

Instead, Project Jupyter source code is the collective copyright of its
contributors. If individual contributors want to maintain a record of what
changes or contributions they have specific copyright on, they should indicate
their copyright in the commit message of the change when they commit the

This comment has been minimized.

Copy link
@afshin

afshin Sep 9, 2019

Member

I don't have an objection to this language because it specifically says this is to maintain a record. It still remains the case that a copyright holder's rights are intact irrespective of whether they explicitly say so.

The language in this clause does make it sound a little bit like those copyright notices should be in commit messages, but I think a close reading of this is actually correct, so I am not proposing a change. I am commenting here for clarity and also to invite disagreement if I've misunderstood.

This comment has been minimized.

Copy link
@jasongrout

jasongrout Sep 9, 2019

Author Member

I had the same thoughts - the existing language was technically fine (though a bit awkward grammatically?), so I hesitated to change it too much.

@fperez
fperez approved these changes Sep 9, 2019
Copy link
Member

left a comment

These look good to me, no objection. Thanks @jasongrout!

@ivanov
ivanov approved these changes Sep 11, 2019

Copyright (c) YEAR Project Jupyter Contributors.

This comment has been minimized.

Copy link
@ivanov

ivanov Sep 11, 2019

Member

should YEAR here remain a placeholder, or do we put 2015, cribbing from the proposed deletion?

This comment has been minimized.

Copy link
@jasongrout

jasongrout Sep 11, 2019

Author Member

Good question. I figured the year would change depending on when that specific repo was started, so I left it a placeholder.

(also known as New or Revised or 3-Clause BSD), as follows:

- Copyright (c) 2001-2015, IPython Development Team
- Copyright (c) 2015-, Jupyter Development Team

This comment has been minimized.

Copy link
@ivanov

ivanov Sep 11, 2019

Member

does this deletion retroactively change the copyright that used to be there? I would have thought that any previous BSD license copyrights would remain in place, but maybe it's not a big deal here.

This comment has been minimized.

Copy link
@jasongrout

jasongrout Sep 11, 2019

Author Member

I think probably Jupyter Development Team can be (optionally?) changed to Project Jupyter Contributors. I think any other copyrights probably ought to be left in place, and the Project Jupyter Contributors copyright should be appended. Thoughts?

This comment has been minimized.

Copy link
@damianavila

damianavila Sep 13, 2019

Member

I think any other copyrights probably ought to be left in place, and the Project Jupyter Contributors copyright should be appended.

Makes sense to me.

@ivanov

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

cookies for anyone coming here from the Steering Council email list. 🍪

@ivanov

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

🍪 🍪 🥛 🍰 🍫 🎁 ☕️

@minrk
minrk approved these changes Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.